MaxLineLength should not raise any finding inside a raw string #5079
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5079 +/- ##
=========================================
Coverage 84.87% 84.87%
- Complexity 3575 3576 +1
=========================================
Files 500 500
Lines 11785 11793 +8
Branches 2197 2198 +1
=========================================
+ Hits 10002 10009 +7
Misses 692 692
- Partials 1091 1092 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I am sorry, but this does not work at all. Your test cases seem to "work" because there is a return statement that prevents further checks. Also there are some test cases that I assume should be failing if we allow multi line strings to contain long lines.
|
@marschwar I'll add some more different tests 👍 |
| @@ -97,6 +108,7 @@ class MaxLineLength(config: Config = Config.empty) : Rule(config) { | |||
| companion object { | |||
| private const val DEFAULT_IDEA_LINE_LENGTH = 120 | |||
| private val BLANK_OR_QUOTES = """[\s"]*""".toRegex() | |||
| private const val TQ = "\"\"\"" | |||
There was a problem hiding this comment.
You shouldn't need to look for """. You should check the parent of those chars that are "MaxLineLength" and see if its type is KtStringTemplateExpression.
closes: #5060