Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnnecessaryInnerClass: add test for safe qualified expressions #4864

Merged
merged 1 commit into from May 27, 2022
Merged

UnnecessaryInnerClass: add test for safe qualified expressions #4864

merged 1 commit into from May 27, 2022

Commits on May 26, 2022

  1. UnnecessaryInnerClass: add test for safe qualified expressions

    Add a unit test for a bug in which safe qualified references to a nullable field
    in the parent class (i.e. as `?.`) would not be marked as warnings in release
    1.20.0. This issue has been inadvertently fixed by
    #4738, but adding a unit test will guard
    against future regressions.
    
    I was able to confirm this test fails by checking out the 1.20.0 tag and running
    the unit test; against that tag the fix was to override the
    visitSafeQualifiedExpression() function with the same logic as
    visitCallExpression().
    dzirbel committed May 26, 2022
    Copy the full SHA
    a43bc03 View commit details
    Browse the repository at this point in the history