Fix UP-TO-DATE checks for functionalTest
#4761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## nc/composite-build #4761 +/- ##
=====================================================
Coverage 84.69% 84.69%
Complexity 3413 3413
=====================================================
Files 490 490
Lines 11232 11232
Branches 2065 2065
=====================================================
Hits 9513 9513
Misses 675 675
Partials 1044 1044 Continue to review full report at Codecov.
|
3flex
approved these changes
Apr 25, 2022
|
@chao2zhang I'll leave this to you to merge (I believe we want to keep on a separate branch right)? |
|
What I am thinking is to keep a live branch for all gradle enterprise experiments. |
|
Yup. Closing as the solution you proposed is more aligned with the codebase style |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #4751
This fixes a failure on a UP-TO-DATE checks for
functionalTest.Proof: https://ge.detekt.dev/c/c52dhidy2tdqc/tcq346kqad2pq/task-inputs
The problem was that this specific test was generating output (i.e. a detekt HTML report) in a resource folder. Solved by reading the resource folder and copying the content inside a temp folder.
(cc @chao2zhang @runningcode as they have context).