Skip to content

Commit

Permalink
Rename rule to ViolatesTypeResolutionRequirements
Browse files Browse the repository at this point in the history
  • Loading branch information
cortinico committed Oct 16, 2022
1 parent bf3f86a commit c4bdd5c
Show file tree
Hide file tree
Showing 21 changed files with 22 additions and 22 deletions.
2 changes: 1 addition & 1 deletion config/detekt/detekt.yml
Expand Up @@ -279,6 +279,6 @@ libraries:
includes: ['**/detekt-api/src/main/**/api/*.kt']

ruleauthors:
ViolateTypeResolutionRequirements:
ViolatesTypeResolutionRequirements:
active: true
excludes: ['**/test/**', '**/*Test.kt', '**/*Spec.kt']
Expand Up @@ -8,7 +8,7 @@ import org.jetbrains.kotlin.psi.KtFile
* scanning the source code line by line to increase performance.
*/
@Deprecated("multi rules are much more difficult to maintain and support will be removed in the future")
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
abstract class MultiRule : BaseRule() {

abstract val rules: List<Rule>
Expand Down
Expand Up @@ -28,7 +28,7 @@ import org.jetbrains.kotlin.psi.KtSecondaryConstructor
/**
* Reports functions and constructors which have more parameters than a certain threshold.
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
@ActiveByDefault(since = "1.0.0")
class LongParameterList(config: Config = Config.empty) : Rule(config) {
override val issue = Issue(
Expand Down
Expand Up @@ -42,7 +42,7 @@ import org.jetbrains.kotlin.resolve.calls.util.getType
* str.toLowerCase(Locale.US)
* </compliant>
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
@ActiveByDefault(since = "1.16.0")
class ImplicitDefaultLocale(config: Config = Config.empty) : Rule(config) {

Expand Down
Expand Up @@ -28,7 +28,7 @@ import org.jetbrains.kotlin.psi.psiUtil.containingClass
* }
* </noncompliant>
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
class LateinitUsage(config: Config = Config.empty) : Rule(config) {

override val issue = Issue(
Expand Down
Expand Up @@ -43,7 +43,7 @@ import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe
* map.getOrElse("key", { "" })
* </compliant>
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
@ActiveByDefault(since = "1.21.0")
class MapGetWithNotNullAssertionOperator(config: Config) : Rule(config) {

Expand Down
Expand Up @@ -44,7 +44,7 @@ import org.jetbrains.kotlin.types.typeUtil.isSubtypeOf
* }
* </compliant>
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
@ActiveByDefault(since = "1.21.0")
class InstanceOfCheckForException(config: Config = Config.empty) : Rule(config) {

Expand Down
Expand Up @@ -52,7 +52,7 @@ import org.jetbrains.kotlin.resolve.BindingContext
* }
* </compliant>
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
@ActiveByDefault(since = "1.2.0")
class MemberNameEqualsClassName(config: Config = Config.empty) : Rule(config) {

Expand Down
Expand Up @@ -50,7 +50,7 @@ import org.jetbrains.kotlin.resolve.calls.util.getResolvedCall
* }
* </compliant>
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
@ActiveByDefault(since = "1.0.0")
class SpreadOperator(config: Config = Config.empty) : Rule(config) {

Expand Down
Expand Up @@ -16,7 +16,7 @@ class RuleAuthorsProvider : RuleSetProvider {
override fun instance(config: Config) = RuleSet(
ruleSetId,
listOf(
ViolateTypeResolutionRequirements(config),
ViolatesTypeResolutionRequirements(config),
)
)
}
Expand Up @@ -28,7 +28,7 @@ import kotlin.reflect.KClass
*/
@ActiveByDefault("1.22.0")
@RequiresTypeResolution
class ViolateTypeResolutionRequirements(config: Config = Config.empty) : Rule(config) {
class ViolatesTypeResolutionRequirements(config: Config = Config.empty) : Rule(config) {
override val issue = Issue(
javaClass.simpleName,
Severity.Defect,
Expand Down
@@ -1,4 +1,4 @@
ruleauthors:
active: true
ViolateTypeResolutionRequirements:
ViolatesTypeResolutionRequirements:
active: true
Expand Up @@ -7,9 +7,9 @@ import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment
import org.junit.jupiter.api.Test

@KotlinCoreEnvironmentTest
internal class ViolateTypeResolutionRequirementsSpec(private val env: KotlinCoreEnvironment) {
internal class ViolatesTypeResolutionRequirementsSpec(private val env: KotlinCoreEnvironment) {

private val rule = ViolateTypeResolutionRequirements()
private val rule = ViolatesTypeResolutionRequirements()

@Test
fun `should not report classes that don't extend from BaseRule`() {
Expand Down
Expand Up @@ -35,7 +35,7 @@ import org.jetbrains.kotlin.psi.psiUtil.containingClass
* const val constantString = "1"
* </compliant>
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
@ActiveByDefault(since = "1.2.0")
class FunctionOnlyReturningConstant(config: Config = Config.empty) : Rule(config) {

Expand Down
Expand Up @@ -44,7 +44,7 @@ import org.jetbrains.kotlin.types.typeUtil.isInterface
* }
* </noncompliant>
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
@ActiveByDefault(since = "1.2.0")
class UnnecessaryAbstractClass(config: Config = Config.empty) : Rule(config) {

Expand Down
Expand Up @@ -28,7 +28,7 @@ import org.jetbrains.kotlin.resolve.descriptorUtil.getImportableDescriptor
* Exempt from this rule are imports resulting from references to elements within KDoc and
* from destructuring declarations (componentN imports).
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
class UnusedImports(config: Config) : Rule(config) {

override val issue = Issue(
Expand Down
Expand Up @@ -56,7 +56,7 @@ private const val ARRAY_GET_METHOD_NAME = "get"
* If these private elements are unused they should be removed. Otherwise, this dead code
* can lead to confusion and potential bugs.
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
@ActiveByDefault(since = "1.16.0")
class UnusedPrivateMember(config: Config = Config.empty) : Rule(config) {

Expand Down
Expand Up @@ -37,7 +37,7 @@ import org.jetbrains.kotlin.psi.KtThrowExpression
* }
* </compliant>
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
@ActiveByDefault(since = "1.21.0")
class UseCheckOrError(config: Config = Config.empty) : Rule(config) {

Expand Down
Expand Up @@ -45,7 +45,7 @@ import org.jetbrains.kotlin.types.KotlinType
* class A(val b: B) : I by b
* </compliant>
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
class UseDataClass(config: Config = Config.empty) : Rule(config) {

override val issue: Issue = Issue(
Expand Down
Expand Up @@ -29,7 +29,7 @@ import org.jetbrains.kotlin.psi.KtThrowExpression
* require(value >= 0) { "value is $value but should be at least 0" }
* </compliant>
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
@ActiveByDefault(since = "1.21.0")
class UseRequire(config: Config = Config.empty) : Rule(config) {

Expand Down
Expand Up @@ -50,7 +50,7 @@ import org.jetbrains.kotlin.utils.addToStdlib.firstIsInstanceOrNull
* override fun foo() = Unit
* </compliant>
*/
@Suppress("ViolateTypeResolutionRequirements")
@Suppress("ViolatesTypeResolutionRequirements")
class OptionalUnit(config: Config = Config.empty) : Rule(config) {

override val issue = Issue(
Expand Down

0 comments on commit c4bdd5c

Please sign in to comment.