Enable gradle worker api

detekt · Feb 2, 2024 · b88e93e · b88e93e
1 parent 7465bd4
commit b88e93e
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/...dle-plugin/src/functionalTest/kotlin/io/gitlab/arturbosch/detekt/DetektReportMergeSpec.kt b/...dle-plugin/src/functionalTest/kotlin/io/gitlab/arturbosch/detekt/DetektReportMergeSpec.kt
@@ -55,13 +55,15 @@ class DetektReportMergeSpec {
             assertThat(result.output).containsIgnoringWhitespaces(
                 """
                     Execution failed for task ':child1:detekt'.
-                    > Analysis failed with 2 issues.
+                    > A failure occurred while executing io.gitlab.arturbosch.detekt.invoke.DetektWorkAction
+                        > Analysis failed with 2 issues.
                 """.trimIndent()
             )
             assertThat(result.output).containsIgnoringWhitespaces(
                 """
                     Execution failed for task ':child2:detekt'.
-                    > Analysis failed with 4 issues.
+                    > A failure occurred while executing io.gitlab.arturbosch.detekt.invoke.DetektWorkAction
+                        > Analysis failed with 4 issues.
                 """.trimIndent()
             )
             assertThat(projectFile("build/reports/detekt/detekt.sarif")).doesNotExist()
@@ -121,13 +123,15 @@ class DetektReportMergeSpec {
             assertThat(result.output).containsIgnoringWhitespaces(
                 """
                     Execution failed for task ':child1:detekt'.
-                    > Analysis failed with 2 issues.
+                    > A failure occurred while executing io.gitlab.arturbosch.detekt.invoke.DetektWorkAction
+                        > Analysis failed with 2 issues.
                 """.trimIndent()
             )
             assertThat(result.output).containsIgnoringWhitespaces(
                 """
                     Execution failed for task ':child2:detekt'.
-                    > Analysis failed with 4 issues.
+                    > A failure occurred while executing io.gitlab.arturbosch.detekt.invoke.DetektWorkAction
+                        > Analysis failed with 4 issues.
                 """.trimIndent()
             )
             assertThat(projectFile("build/reports/detekt/detekt.xml")).doesNotExist()

diff --git a/detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/Detekt.kt b/detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/Detekt.kt
@@ -214,7 +214,7 @@ abstract class Detekt @Inject constructor(
 
     @TaskAction
     fun check() {
-        if (providers.gradleProperty(USE_WORKER_API).getOrElse("false") == "true") {
+        if (providers.gradleProperty(USE_WORKER_API).getOrElse("true").toBoolean()) {
             logger.info("Executing $name using Worker API")
             val workQueue = workerExecutor.processIsolation { workerSpec ->
                 workerSpec.classpath.from(detektClasspath)

diff --git a/detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/DetektCreateBaselineTask.kt b/detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/DetektCreateBaselineTask.kt
@@ -143,7 +143,7 @@ abstract class DetektCreateBaselineTask @Inject constructor(
 
     @TaskAction
     fun baseline() {
-        if (providers.gradleProperty(USE_WORKER_API).getOrElse("false") == "true") {
+        if (providers.gradleProperty(USE_WORKER_API).getOrElse("true").toBoolean()) {
             logger.info("Executing $name using Worker API")
             val workQueue = workerExecutor.processIsolation { workerSpec ->
                 workerSpec.classpath.from(detektClasspath)

diff --git a/detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/DetektGenerateConfigTask.kt b/detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/DetektGenerateConfigTask.kt
@@ -57,7 +57,7 @@ abstract class DetektGenerateConfigTask @Inject constructor(
 
         Files.createDirectories(configFile.get().asFile.parentFile.toPath())
 
-        if (providers.gradleProperty(USE_WORKER_API).getOrElse("false") == "true") {
+        if (providers.gradleProperty(USE_WORKER_API).getOrElse("true").toBoolean()) {
             logger.info("Executing $name using Worker API")
             val workQueue = workerExecutor.processIsolation { workerSpec ->
                 workerSpec.classpath.from(detektClasspath)

diff --git a/website/docs/gettingstarted/gradle.mdx b/website/docs/gettingstarted/gradle.mdx
@@ -310,7 +310,7 @@ detekt {
 ### <a name="gradle-properties">Options for detekt Gradle properties</a>
 
 ```groovy
-// If set to true, enables Gradle Worker API for Detekt tasks. `false` by default.
+// If set to true, enables Gradle Worker API for Detekt tasks. `true` by default.
 // See the doc for the Worker API at https://docs.gradle.org/8.1/userguide/worker_api.html
 detekt.use.worker.api = false
 ```