build(deps): update Cosmos to v0.44.3 #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
RiccardoM
changed the title
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
=======================================
Coverage 15.78% 15.78%
=======================================
Files 169 169
Lines 45993 45993
=======================================
Hits 7262 7262
Misses 38108 38108
Partials 623 623 Continue to review full report at Codecov.
|
RiccardoM
commented
Nov 2, 2021
Comment on lines
+73
to
+76
| initClientCtx, err := client.ReadPersistentCommandFlags(initClientCtx, cmd.Flags()) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
This is required by Cosmos v0.44.3 and above as the ReadHomeFlag function has been removed
…upgrade-cosmos � Conflicts: � go.sum
dadamu
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates Cosmos to
v0.44.3and also cherry picks the changes that have been made inside cosmos/cosmos-sdk#8590 to fix the issue described in cosmos/cosmos-sdk#10428Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change