Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use parse_err constructor instead of literal #291

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Aug 17, 2023

This PR applied parse_err constructor, it reduces a feature inside desmos-std-derive.

See: CosmWasm/cosmwasm#1760

@dadamu
Copy link
Contributor Author

dadamu commented Aug 17, 2023

The error would be the last nightly version issue:

The passed rust version is nightly-2023-08-14
https://github.com/desmos-labs/desmos-bindings/actions/runs/5859871379/job/15886768091#step:4:27

The current failed rust version is nightly-2023-08-17
https://github.com/desmos-labs/desmos-bindings/actions/runs/5889901942/job/15973955488?pr=291#step:4:27

@manu0466
Copy link

@dadamu, can we use the current latest version of Rust 1.71.0 instead of the nightly build?

@dadamu
Copy link
Contributor Author

dadamu commented Aug 18, 2023

@manu0466 Yes, if we disable backtraces features then we can use latest stable version since backtrances involves in many nightly unstable features.

I created a PR to fix the issue: #296

@dadamu dadamu requested a review from manu0466 August 18, 2023 07:08
@dadamu dadamu force-pushed the paul/use-std-err-contstructor branch from 6601731 to 87f6c53 Compare August 21, 2023 08:39
@dadamu
Copy link
Contributor Author

dadamu commented Aug 25, 2023

@manu0466 Rebased

@manu0466 manu0466 merged commit e1251a2 into main Aug 28, 2023
8 checks passed
@manu0466 manu0466 deleted the paul/use-std-err-contstructor branch August 28, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants