Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add remarkables utils #10

Merged
merged 25 commits into from Nov 3, 2022
Merged

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Oct 7, 2022

This PR adds remarkable utils.
It is waiting for upstream to fix type:

@dadamu dadamu marked this pull request as ready for review October 11, 2022 15:22
@dadamu
Copy link
Contributor Author

dadamu commented Oct 11, 2022

After the fix release, it can work properly.

types/package.json Show resolved Hide resolved
types/package.json Outdated Show resolved Hide resolved
@manu0466
Copy link

Please also update the README.md inside the utils dir with the new scripts

@dadamu dadamu requested a review from manu0466 October 13, 2022 02:55
Copy link

@manu0466 manu0466 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update also the README.md inside the utils dir with the newly added remarkables and cw721-remarkables scripts.

@dadamu dadamu requested a review from manu0466 October 14, 2022 03:30
Copy link

@manu0466 manu0466 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

@manu0466 manu0466 merged commit 8a730cd into main Nov 3, 2022
@manu0466 manu0466 deleted the paul/DCD-83/add-remarkables-utils branch November 3, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants