Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "allow JIT" entitlement to macOS builds #16012

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

sergiou87
Copy link
Member

@sergiou87 sergiou87 commented Jan 26, 2023

Closes #16011

Description

This PR fixes a crash that was introduced in Electron 22 only for macOS builds running on Apple silicon devices. The fix is suggested here: electron/electron#35355 (comment)

It seems the entitlement this PR adds was included long time ago but then was removed: c7467b1

Release notes

Notes: [Fixed] Fix crash launching the app on Apple silicon devices

Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergiou87 sergiou87 merged commit 0b04ff3 into development Jan 26, 2023
@sergiou87 sergiou87 deleted the fix-electron-22-on-arm64 branch January 26, 2023 14:58
@sergiou87 sergiou87 mentioned this pull request Jan 26, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Desktop Beta crushing on apple silicon chip after instaling the latest
3 participants