Bump Electron to v22.0.3 #15831
Bump Electron to v22.0.3 #15831
Conversation
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
|
Since opening this, there was have been a few patches to 22. Thus, I have bumped to 22.0.3 |
| @@ -140,7 +140,7 @@ export class OrderedWebRequest { | |||
| this.onBeforeRequest = new AsyncListenerSet( | |||
| webRequest.onBeforeRequest.bind(webRequest), | |||
| async (listeners, details) => { | |||
| let response: Response = {} | |||
| let response: CallbackResponse = {} | |||
There was a problem hiding this comment.
Same update to api as explained in #15828
|
Tested locally on my macOS - Test deployment pending and will test out on Windows. |
There was a problem hiding this comment.
Code looks good and I tested it on macOS and Windows and worked as expected!
I tested not only the most basic use cases, but also those which involve doing some "system stuff" (opening the browser, handling our custom url scheme, notifications, moving repos to the recycle bin, "open file" dialog…)
I also opened the latest beta right after this test build and it kept my list of repositories and settings, so it seems to be backwards compatible in that regard 😌
Description
We discussed moving to v21.3.3 to stay 1 version behind. I have that PR open and am testing it out (
release 3.1.3-test1 is test build with itrelease 3.1.3-test4 has newer node).However... I think we will have some release churning with the start of the new year and since the Electron release cadence appears to be every 2 months.. A new version could be as soon as the end of January/first of February. Assuming we are going to keep Electron on beta for a few weeks. Moving to 22 for beta could likely land us 1 version behind by the time we release to prod.
Thus, I just spun up a this branch to see if moving to v22.0.0 brought any trouble and it appears pretty straight forward so far.
This PR upgrades Electron to v22.0.3!
A couple of pretty simple type changes were required:
PathTypetype used byElectron.App.getPath(pathType)no longer has a type of'cache'and has added a type of'sessionData'. This doesn't affect as we only use the PathTypes of'document'and'home'.Electron.Responseand replaced it withElectron.CallbackResponse. This does not have a programmatic impact on us asElectron.CallbackResponsehas the same properties asElectron.Responseused to have.app. on('new-window'...event has been deprecated since 13 and removed in 22. Added the recommended fix. I am not 100% it works as expected as I couldn't replicate log from old version.. :/Node Notes: Node v16.14.0 is latest with arm64 builds and thus that is what I bumped it to; however, Electron 22 uses node v16.17.1 and so I have requested it in the arm64 build thread. When we get that build, we will want to bump accordingly.It was generated for us nodejs/build#2540 (comment) ❤️