Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Electron to 19.0.13 #15191

Closed
wants to merge 1 commit into from
Closed

Bump Electron to 19.0.13 #15191

wants to merge 1 commit into from

Conversation

mamantoha
Copy link

No description provided.

@sergiou87
Copy link
Member

Thank you for your PR! However, we require PRs to follow the template. In any case, bumping Electron is something we have to do carefully and after a ton of testing, since those upgrades tend to introduce regressions.

If you have any reason to upgrade Electron to 19.0.13, we'd love to hear it, but for now we're not going beyond 19.0.0.

@sergiou87 sergiou87 closed this Aug 30, 2022
@mamantoha
Copy link
Author

@sergiou87 got it. Electron v19.0.9 fixes empty app_id when running under Wayland - electron/electron#34855. Without this GitHub Desktop doesn't have an icon in Task Switcher.

@mamantoha mamantoha deleted the upgrade-to-electron-19.0.13 branch August 30, 2022 14:20
@sergiou87
Copy link
Member

Oh, thanks for clarifying @mamantoha 🙇‍♂️

Unfortunately that doesn't seem urgent enough to force this kind of (dangeours) upgrade, especially since we don't officially support Linux (sorry!!).

In any case, we'll have to upgrade eventually, and you'll get that fix in.

Sorry I don't bring better news 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants