Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI binary installation #3

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Conversation

peytondmurray
Copy link
Collaborator

@peytondmurray peytondmurray commented Nov 16, 2022

This PR adds a configuration setting to install the rust nbstripout-fast CLI to the python binary directory, so that users can easily launch the CLI after installing.

@peytondmurray peytondmurray marked this pull request as ready for review November 17, 2022 02:12
@peytondmurray
Copy link
Collaborator Author

Hmm, looks like we can't yet ship multiple targets with maturin, but that should be something we can do soon. Let me see if we can find a workaround.

@peytondmurray
Copy link
Collaborator Author

One workaround would be to write a python wrapper for the rust CLI :/. Not ideal. Let me see how hard it would be to add multiple targets in maturin.

@mlucool
Copy link
Member

mlucool commented Nov 17, 2022

Yeah, the idea is creating a bin for deploy and python bindings for test. I don't think we need both today.

@peytondmurray
Copy link
Collaborator Author

In that case, I think it makes sense to disable this test for now until the upstream change in maturin to support multiple build targets is merged. What do you think?

@peytondmurray
Copy link
Collaborator Author

Build issues on macos look like they're upstream: PyO3/maturin#1080

@mlucool
Copy link
Member

mlucool commented Nov 19, 2022

Build issues on macos look like they're upstream: PyO3/maturin#1080

Let's disable macos and leave a reference to this issue as a comment?

@mlucool
Copy link
Member

mlucool commented Nov 19, 2022

@peytondmurray let's try PyO3/maturin#1080 (comment) first?

@peytondmurray
Copy link
Collaborator Author

@mlucool Looks like there's an issue deeper in pyo3 that is blocking our ability to disable the extension-module as suggested in PyO3/maturin#1080 (comment). How do you want to proceed here? I think the quickest thing to do is disable macOS wheel builds for now and add them back when the issue is resolved.

@mlucool
Copy link
Member

mlucool commented Dec 3, 2022

Yeah, let's drop osx for now and cross-link to the issue

@mlucool mlucool merged commit cf10844 into deshaw:main Dec 6, 2022
@peytondmurray peytondmurray deleted the add-bin branch December 6, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants