[TASK] Be more strict in tests

Refs #1088 Signed-off-by: Torben Hansen <derhansen@gmail.com>
derhansen · Apr 6, 2023 · 719452b · 719452b
1 parent 3ddcc92
commit 719452b
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 13 deletions.
diff --git a/Tests/Unit/Controller/AdministrationControllerTest.php b/Tests/Unit/Controller/AdministrationControllerTest.php
@@ -34,7 +34,7 @@ protected function setUp(): void
     {
         $this->subject = $this->getAccessibleMock(
             AdministrationController::class,
-            ['redirect', 'forward', 'addFlashMessage', 'redirectToUri', 'getLanguageService', 'initModuleTemplateAndReturnResponse'],
+            ['redirect', 'addFlashMessage', 'redirectToUri', 'getLanguageService', 'initModuleTemplateAndReturnResponse'],
             [],
             '',
             false

diff --git a/Tests/Unit/Controller/EventControllerTest.php b/Tests/Unit/Controller/EventControllerTest.php
@@ -70,7 +70,6 @@ protected function setUp(): void
             EventController::class,
             [
                 'redirect',
-                'forward',
                 'addFlashMessage',
                 'overwriteEventDemandObject',
                 'getSysLanguageUid',
@@ -111,7 +110,7 @@ public function overwriteDemandObjectIgnoresIgnoredProperties()
 
         $mockController = $this->getAccessibleMock(
             EventController::class,
-            ['redirect', 'forward', 'addFlashMessage'],
+            ['redirect', 'addFlashMessage'],
             [],
             '',
             false
@@ -132,7 +131,7 @@ public function overwriteDemandObjectSetsCategoryProperty()
 
         $mockController = $this->getAccessibleMock(
             EventController::class,
-            ['redirect', 'forward', 'addFlashMessage'],
+            ['redirect', 'addFlashMessage'],
             [],
             '',
             false
@@ -2126,7 +2125,7 @@ public function handleEventNotFoundShows404Page()
 
         $this->expectExceptionCode(1631261423);
         $this->expectException(PropagateResponseException::class);
-        $mock = $this->getAccessibleMock(EventController::class, ['dummy']);
+        $mock = $this->getAccessibleMock(EventController::class, null);
         $mock->_set('request', $request);
         $mock->_call('handleEventNotFoundError', $settings);
     }
@@ -2182,7 +2181,7 @@ public function changeEventDemandToFullMonthDateRangeAppliesExpectedDatesAndUnse
 
         $mockController = $this->getAccessibleMock(
             EventController::class,
-            ['redirect', 'forward', 'addFlashMessage'],
+            ['redirect', 'addFlashMessage'],
             [],
             '',
             false
@@ -2207,7 +2206,7 @@ public function changeEventDemandToFullMonthDateRangeAppliesExpectedDatesAndUnse
      */
     public function checkPidOfEventRecordWorks()
     {
-        $mockedController = $this->getAccessibleMock(EventController::class, ['dummy']);
+        $mockedController = $this->getAccessibleMock(EventController::class, null);
 
         $event = new Event();
 
@@ -2241,7 +2240,7 @@ public function checkPidOfEventRecordWorks()
      */
     public function evaluateSingleEventSettingIsWorking()
     {
-        $mockedController = $this->getAccessibleMock(EventController::class, ['dummy']);
+        $mockedController = $this->getAccessibleMock(EventController::class, null);
         // singleEvent setting not configured not configured
         $mockedController->_set('settings', ['singleEvent' => null]);
         self::assertNull($mockedController->_call('evaluateSingleEventSetting', null));
@@ -2266,7 +2265,7 @@ public function evaluateSingleEventSettingIsWorking()
      */
     public function evaluateIsShortcutSettingIsWorking()
     {
-        $mockedController = $this->getAccessibleMock(EventController::class, ['dummy']);
+        $mockedController = $this->getAccessibleMock(EventController::class, null);
 
         // isShortcut not configured
         $mockedController->_set('settings', ['detail' => ['isShortcut' => 0]]);
@@ -2275,7 +2274,7 @@ public function evaluateIsShortcutSettingIsWorking()
         // isShortcut is configured
         $mockEvent = $this->getMockBuilder(Event::class)->getMock();
 
-        $mockContentObjectRenderer = $this->getAccessibleMock(ContentObjectRenderer::class, ['dummy']);
+        $mockContentObjectRenderer = $this->getAccessibleMock(ContentObjectRenderer::class, null);
         $mockContentObjectRenderer->_set('data', ['uid' => 123]);
 
         $mockConfigurationManager = $this->getMockBuilder(ConfigurationManager::class)

diff --git a/Tests/Unit/Service/EventPlausabilityServiceTest.php b/Tests/Unit/Service/EventPlausabilityServiceTest.php
@@ -51,7 +51,7 @@ public function isStartDateBeforeEndDateDataProvider(): array
      */
     public function isStartDateBeforeEndDateReturnsExpectedResults(int $startdate, int $enddate, bool $expected): void
     {
-        $service = $this->getAccessibleMock(EventPlausabilityService::class, ['dummy'], [], '', false);
+        $service = $this->getAccessibleMock(EventPlausabilityService::class, null, [], '', false);
         self::assertEquals($expected, $service->_call('isStartDateBeforeEndDate', $startdate, $enddate));
     }
 

diff --git a/Tests/Unit/Service/SpamCheckServiceTest.php b/Tests/Unit/Service/SpamCheckServiceTest.php
@@ -96,7 +96,7 @@ public function maxSpamScoreIsSetInConstructor(): void
         ];
         $arguments = [];
 
-        $service = $this->getAccessibleMock(SpamCheckService::class, ['dummy'], [$registration, $settings, $arguments]);
+        $service = $this->getAccessibleMock(SpamCheckService::class, null, [$registration, $settings, $arguments]);
         self::assertEquals(20, $service->_get('maxSpamScore'));
     }
 
@@ -111,7 +111,7 @@ public function emptyCheckArrayIsInitializedInConstructor(): void
         ];
         $arguments = [];
 
-        $service = $this->getAccessibleMock(SpamCheckService::class, ['dummy'], [$registration, $settings, $arguments]);
+        $service = $this->getAccessibleMock(SpamCheckService::class, null, [$registration, $settings, $arguments]);
         self::assertEquals([], $service->_get('settings')['checks']);
     }