Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krew manifest update #294

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Conversation

mstoops
Copy link
Contributor

@mstoops mstoops commented Mar 8, 2024

I think this might fix your Krew action. Your original .krew.yaml didn't work when run through the krew-release-bot Docker container (see https://github.com/rajatjindal/krew-release-bot?tab=readme-ov-file#testing-the-template-file). The updated .krew.yaml does, you can try using:

docker run -v $PWD/.krew.yaml:/tmp/template-file.yaml ghcr.io/rajatjindal/krew-release-bot:v0.0.46 krew-release-bot template --tag v0.20.5 --template-file /tmp/template-file.yaml

@mstoops mstoops marked this pull request as ready for review March 8, 2024 20:02
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mstoops Thank you for this update Matthew!
I couldn't verify since the docker img chokes on arm64 ;( but this update looks correct.

@derailed derailed merged commit c9be471 into derailed:master Mar 9, 2024
3 checks passed
@derailed derailed mentioned this pull request Mar 9, 2024
@derailed
Copy link
Owner

derailed commented Mar 9, 2024

@mstoops ;( Looks like this is still a dud ;( I don't think I've ever seen this gha working.
Will need to debug to see what's missing

@mstoops
Copy link
Contributor Author

mstoops commented Mar 11, 2024

Well that is frustrating! It's interesting that in the Action failures, it has a link that 404s. If you click on it, it's a link with a ':' on the end. If you strip the colon, then the file found. Could be a red herring, but still strange.

@mstoops mstoops deleted the krew-manifest-update branch March 19, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants