Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added regexp to match server versions without plus #182

Conversation

WillBartee
Copy link

Extended fix for #170

As seen in some of the server versions reported in #170, there is not always a + included in the minor version.

The regexp match handles situation where the + is not included in the minor version provided by the server.

@WillBartee
Copy link
Author

WillBartee commented Jul 16, 2021

Closing in lieu of:

  • changes in v0.9.5 to remove + from minor version checks
  • suggested future work
    • ... we need a more generic solution. I'll take a crack at it in the next drop and see if we're happier...
      from: issue #188

  • Work done in POP-188: fix #188 and #178 #189

@WillBartee WillBartee closed this Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant