Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #539

Merged
merged 14 commits into from
Jul 13, 2022
Merged

chore: update dependencies #539

merged 14 commits into from
Jul 13, 2022

Conversation

michael-siek
Copy link
Member

@michael-siek michael-siek commented Jul 8, 2022

See: #538

@michael-siek michael-siek marked this pull request as ready for review July 8, 2022 16:32
@michael-siek michael-siek requested a review from a team July 11, 2022 13:09
Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one thing about CLI ChromeDriver

"axe-core": "^4.4.1",
"chromedriver": "latest",
"axe-core": "^4.4.2",
"chromedriver": "^103.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep latest here for any subsequent installs of CLI to allow users to just reinstall CLI when the chromedriver goes x version out of date, would save us releasing a patch version just to update our chromedriver version I think

Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-siek michael-siek merged commit fcfa37c into develop Jul 13, 2022
@michael-siek michael-siek deleted the chore/dependency-day branch July 13, 2022 14:42
@heeboA
Copy link

heeboA commented Jul 20, 2022

This apparently isn't released yet. Any news on when it will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants