Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added directory, package-ecosystem and target_branch to output #139

Merged
merged 7 commits into from Feb 11, 2022

Conversation

mwaddell
Copy link
Contributor

@mwaddell mwaddell commented Feb 7, 2022

closes issue #76

@mwaddell mwaddell requested a review from a team as a code owner February 7, 2022 23:40
@Nishnha
Copy link
Member

Nishnha commented Feb 9, 2022

This makes sense. Since the branch name already contains the directory path, I don't think we should have any security concerns with including this info in our output.

Nice work 👍🏾

CI Is already passing so I'll just look over the tests and work to get this merged.

Copy link
Member

@Nishnha Nishnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only noticed a few things that need to be changed. Once those are modified this LGTM 👍🏾

src/dependabot/output.ts Show resolved Hide resolved
src/dependabot/update_metadata.test.ts Show resolved Hide resolved
src/dry-run.ts Outdated Show resolved Hide resolved
src/dependabot/update_metadata.ts Show resolved Hide resolved
@Nishnha Nishnha merged commit 9fd8ff4 into dependabot:main Feb 11, 2022
@Nishnha
Copy link
Member

Nishnha commented Feb 11, 2022

After merging this I realized that target-branch is actually hyphenated in our docs https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates#target-branch

I'll follow this PR up with another to rename target_branch to target-branch

@mwaddell
Copy link
Contributor Author

Whoops! - see #140

@mwaddell mwaddell deleted the add_outputs branch February 12, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants