Skip to content

Commit

Permalink
Merge pull request #140 from pangaeatech/fix_name
Browse files Browse the repository at this point in the history
Renaming `target_branch` to `target-branch`
  • Loading branch information
Nishnha committed Feb 11, 2022
2 parents 9fd8ff4 + 7bf7b54 commit 37d2f78
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 14 deletions.
4 changes: 2 additions & 2 deletions README.md
Expand Up @@ -41,8 +41,8 @@ Subsequent actions will have access to the following outputs:
- The `directory` configuration that was used by dependabot for this updated Dependency.
- `steps.dependabot-metadata.outputs.package-ecosystem`
- The `package-ecosystem` configuration that was used by dependabot for this updated Dependency.
- `steps.dependabot-metadata.outputs.target_branch`
- The `target_branch` configuration that was used by dependabot for this updated Dependency.
- `steps.dependabot-metadata.outputs.target-branch`
- The `target-branch` configuration that was used by dependabot for this updated Dependency.

**Note:** These outputs will only be populated if the target Pull Request was opened by Dependabot and contains
**only** Dependabot-created commits.
Expand Down
4 changes: 2 additions & 2 deletions action.yml
Expand Up @@ -20,8 +20,8 @@ outputs:
description: 'The `directory` configuration that was used by dependabot for this updated Dependency.'
package-ecosystem:
description: 'The `package-ecosystem` configuration that was used by dependabot for this updated Dependency.'
target_branch:
description: 'The `target_branch` configuration that was used by dependabot for this updated Dependency.'
target-branch:
description: 'The `target-branch` configuration that was used by dependabot for this updated Dependency.'
runs:
using: 'node12'
main: 'dist/index.js'
4 changes: 2 additions & 2 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions src/dependabot/output.test.ts
Expand Up @@ -34,7 +34,7 @@ test('when given a single dependency it sets its values', async () => {
expect(core.setOutput).toBeCalledWith('update-type', 'version-update:semver-minor')
expect(core.setOutput).toBeCalledWith('directory', 'wwwroot')
expect(core.setOutput).toBeCalledWith('package-ecosystem', 'nuget')
expect(core.setOutput).toBeCalledWith('target_branch', 'main')
expect(core.setOutput).toBeCalledWith('target-branch', 'main')
})

test('when given a multiple dependencies, it uses the highest values for types', async () => {
Expand Down Expand Up @@ -82,7 +82,7 @@ test('when given a multiple dependencies, it uses the highest values for types',
expect(core.setOutput).toBeCalledWith('update-type', 'version-update:semver-major')
expect(core.setOutput).toBeCalledWith('directory', '')
expect(core.setOutput).toBeCalledWith('package-ecosystem', '')
expect(core.setOutput).toBeCalledWith('target_branch', '')
expect(core.setOutput).toBeCalledWith('target-branch', '')
})

test('when the dependency has no update type', async () => {
Expand Down Expand Up @@ -110,7 +110,7 @@ test('when the dependency has no update type', async () => {
expect(core.setOutput).toBeCalledWith('update-type', null)
expect(core.setOutput).toBeCalledWith('directory', '')
expect(core.setOutput).toBeCalledWith('package-ecosystem', '')
expect(core.setOutput).toBeCalledWith('target_branch', '')
expect(core.setOutput).toBeCalledWith('target-branch', '')
})

test('when given a multiple dependencies, and some do not have update types', async () => {
Expand Down Expand Up @@ -158,5 +158,5 @@ test('when given a multiple dependencies, and some do not have update types', as
expect(core.setOutput).toBeCalledWith('update-type', 'version-update:semver-minor')
expect(core.setOutput).toBeCalledWith('directory', '')
expect(core.setOutput).toBeCalledWith('package-ecosystem', '')
expect(core.setOutput).toBeCalledWith('target_branch', '')
expect(core.setOutput).toBeCalledWith('target-branch', '')
})
4 changes: 2 additions & 2 deletions src/dependabot/output.ts
Expand Up @@ -31,7 +31,7 @@ export function set (updatedDependencies: Array<updatedDependency>): void {
core.info(`outputs.update-type: ${updateType}`)
core.info(`outputs.directory: ${directory}`)
core.info(`outputs.package-ecosystem: ${ecosystem}`)
core.info(`outputs.target_branch: ${target}`)
core.info(`outputs.target-branch: ${target}`)
core.endGroup()

core.setOutput('updated-dependencies-json', updatedDependencies)
Expand All @@ -40,7 +40,7 @@ export function set (updatedDependencies: Array<updatedDependency>): void {
core.setOutput('update-type', updateType)
core.setOutput('directory', directory)
core.setOutput('package-ecosystem', ecosystem)
core.setOutput('target_branch', target)
core.setOutput('target-branch', target)
}

function maxDependencyTypes (updatedDependencies: Array<updatedDependency>): string {
Expand Down
4 changes: 2 additions & 2 deletions src/main.test.ts
Expand Up @@ -102,7 +102,7 @@ test('it sets the updated dependency as an output for subsequent actions', async
expect(core.setOutput).toBeCalledWith('update-type', 'version-update:semver-minor')
expect(core.setOutput).toBeCalledWith('directory', '/')
expect(core.setOutput).toBeCalledWith('package-ecosystem', 'nuget')
expect(core.setOutput).toBeCalledWith('target_branch', 'main')
expect(core.setOutput).toBeCalledWith('target-branch', 'main')
})

test('if there are multiple dependencies, it summarizes them', async () => {
Expand Down Expand Up @@ -164,7 +164,7 @@ test('if there are multiple dependencies, it summarizes them', async () => {
expect(core.setOutput).toBeCalledWith('update-type', 'version-update:semver-major')
expect(core.setOutput).toBeCalledWith('directory', 'api/main')
expect(core.setOutput).toBeCalledWith('package-ecosystem', 'npm_and_yarn')
expect(core.setOutput).toBeCalledWith('target_branch', 'trunk')
expect(core.setOutput).toBeCalledWith('target-branch', 'trunk')
})

test('it sets the action to failed if there is an unexpected exception', async () => {
Expand Down

0 comments on commit 37d2f78

Please sign in to comment.