Resolve some Sorbet errors in Terraform #9545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
changed the title
JamieMagee
force-pushed
the
jamiemagee/terraform-sorbet-errors
branch
6 times, most recently
from
d80e562
to
652c776
Compare
JamieMagee
force-pushed
the
jamiemagee/terraform-sorbet-errors
branch
from
409e8ed
to
28da2f5
Compare
brettfo
approved these changes
Apr 25, 2024
bdragon
approved these changes
Apr 29, 2024
bdragon
approved these changes
Apr 29, 2024
|
I'm pretty sure the reason CI won't build branch images for this PR is because it's from a fork: |
|
@bdragon do you need me to recreate the branch in this repo? |
|
@JamieMagee I think so, unfortunately. Sorry for the ping-ponging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the
FileSelectormixin fromFileFetcheras the mixin expectsdependency_filesto be defined. Instead, I extracted the 2 methods that are used inFileFetcher.See the Sorbet documentation for the advice I followed
Recreated from #9404 due to losing write permissions in this repository.