Allow configuring by file so that dependabot creates draft pull requests

[hfvmarques]

Description

What?

This PR adds the possibility that, on dependabot.yml file, the user can choose if dependabot creates draft pull requests by default instead of review for review ones

Why?

Depending on the repository, dependabot creates a lot of pull requests that, not necessarily, gets reviewed immediately. So they stay there ready for review until someone goes, analyse the changelog of the dependency and then decides to approve it or merge it.

How?

• changing the file parser so that it knows how to identify this new parameter, which is draft: true,
• changing github pull request creator so that it creates the pull request with draft: false by default;
• changing github pull request creator so that it creates a pull request with draft: true if that's the case;

Tests

• Automated;
• Manual.

Observations

I don't know to test this manually and would appreciate if someone could help me with it.
This is my first PR in this repo so I hope it's OK the way that I described it and the changes I made in code.

Resolves #1291

[yeikel]

Hey there, I think that your "Why" is not strong enough

Dependabot supports open-pull-requests-limit for this

I believe that this is very limited use case and you can probably accomplish this using a custom Gh action workflow in the meantime. Ie : if user == dependabot -> set the pr as draft

[hfvmarques]

Hey there, I think that your "Why" is not strong enough

Dependabot supports open-pull-requests-limit for this

I believe that this is very limited use case and you can probably accomplish this using a custom Gh action workflow in the meantime. Ie : if user == dependabot -> set the pr as draft

Yeah, sure, I could accomplish it in other ways, and that's what makes development beautiful.

But why not give that opportunity and ease? Dependabot has a lot of ways to do a lot of things, including what you suggested with the pull request limit, and that's a strangle in my opinion.

I think that the possibility to open draft pull requests should be available. But I'm not the one that makes decisions here.

[yeikel]

Hey there, I think that your "Why" is not strong enough

Dependabot supports open-pull-requests-limit for this

I believe that this is very limited use case and you can probably accomplish this using a custom Gh action workflow in the meantime. Ie : if user == dependabot -> set the pr as draft

Yeah, sure, I could accomplish it in other ways, and that's what makes development beautiful.

But why not give that opportunity and ease? Dependabot has a lot of ways to do a lot of things, including what you suggested with the pull request limit, and that's a strangle in my opinion.

I think that the possibility to open draft pull requests should be available. But I'm not the one that makes decisions here.

The problem is that, as I mentioned, the "why" is not strong enough. Just because a pull request is created, it doesn't make it compulsory to be reviewed and merged. It is perfectly fine and valid to leave pull requests open and not review them immediately when they are created by bots

More configuration options are not necessarily better as it can lead to feature creep, so let's wait and see what the community thinks

[hfvmarques]

The problem is that, as I mentioned, the "why" is not strong enough. Just because a pull request is created, it doesn't make it compulsory to be reviewed and merged. It is perfectly fine and valid to leave pull requests open and not review them immediately when they are created by bots

More configuration options are not necessarily better as it can lead to feature creep, so let's wait and see what the community thinks

You're correct. I should've raised this discussion as an issue before going into coding.

[hfvmarques]

@yeikel there is an issue for this already #1291

[yeikel]

@yeikel there is an issue for this already #1291

Ah, thanks for the context. It seems that there are more use cases to justify this

Let's see what the dependabot thinks