Added support for .tool-versions file in Gemfile for Ruby projects #9070
Conversation
bundler/lib/dependabot/bundler/file_updater/lockfile_updater.rb
Outdated
Show resolved
Hide resolved
kpumuk
force-pushed
the
bundler-tool-versions
branch
from
b9be26d
to
b115833
Compare
| @@ -0,0 +1 @@ | |||
| !.tool-versions | |||
There was a problem hiding this comment.
.tool-versions is ignored at the root of the project, and so we need to negate it here to add this file to the fixture project.
kpumuk
force-pushed
the
bundler-tool-versions
branch
3 times, most recently
from
34af3a4
to
bc29131
Compare
kpumuk
force-pushed
the
bundler-tool-versions
branch
2 times, most recently
from
9d122b6
to
3eb8fbd
Compare
kpumuk
force-pushed
the
bundler-tool-versions
branch
2 times, most recently
from
dd8af5c
to
9a3cfeb
Compare
|
Looking forward to this! Thank you @kpumuk |
kpumuk
force-pushed
the
bundler-tool-versions
branch
from
9a3cfeb
to
8b22490
Compare
You and me both :-) I hope this will eventually get attention from maintainers. |
kpumuk
force-pushed
the
bundler-tool-versions
branch
2 times, most recently
from
2c4b4b1
to
06e3e26
Compare
kpumuk
force-pushed
the
bundler-tool-versions
branch
from
06e3e26
to
97a3716
Compare
kpumuk
force-pushed
the
bundler-tool-versions
branch
from
97a3716
to
53bef4d
Compare
|
@deivid-rodriguez seeing you were involved in adding support for this in 
|
|
Hei, I no longer maintain Dependabot. This seems tested and ready to be reviewed though, so since it's been hanging for a couple months, I think it's fine to politely ping some other maintainer and ask for a review. The Dependabot team is usually super keen on taking community contributions, they are just very busy 😅. |
|
@robaiken @landongrindheim you guys have done a lot of great work on the Ruby side of things of Dependabot. Would you have a moment to review/merge? |
kpumuk
force-pushed
the
bundler-tool-versions
branch
from
436b64e
to
0e5fc84
Compare
|
@jurre rebased main and reworded tests to address linter errors in https://github.com/dependabot/dependabot-core/actions/runs/9117390435/job/25068129813 |
|
Thanks everyone! |
sachin-sandhu
force-pushed
the
bundler-tool-versions
branch
from
15c4d57
to
554d708
Compare
…ach pattern separately
… start with when/with/without)
sachin-sandhu
force-pushed
the
bundler-tool-versions
branch
from
554d708
to
231692c
Compare
|
Omg it's been merged! Thank you all 🥳 Edit: works like a charm |
This MR is related to #1033 in a way that it adds support for
.tool-versionsfiles for Ruby projects.Starting with Bunder 2.4.20, it supports specifying Ruby version via
.tool-versions(see rubygems/rubygems#6898 and Specifying a Ruby Version). Unfortunately, Dependabot does not download this file and does not parse Ruby version from it.This MR enables Ruby projects to specify Ruby version in a single file.