Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump friendsofphp/php-cs-fixer to 3.x in /composer/helpers/v1 #5694

Closed
wants to merge 1 commit into from
Closed

Bump friendsofphp/php-cs-fixer to 3.x in /composer/helpers/v1 #5694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 3 additions & 6 deletions composer/helpers/v1/.php-cs-fixer.dist.php
View file
Open in desktop
Expand Up @@ -2,19 +2,16 @@
$finder = PhpCsFixer\Finder::create()
->in(__DIR__ . '/src')
->in(__DIR__ . '/bin');
return PhpCsFixer\Config::create()
$config = new PhpCsFixer\Config();
return $config
->setRules([
'@Symfony' => true,
'array_syntax' => ['syntax' => 'short'],
'blank_line_after_opening_tag' => true,
'concat_space' => ['spacing' => 'one'],
'declare_strict_types' => true,
'increment_style' => ['style' => 'post'],
'is_null' => ['use_yoda_style' => false],
'list_syntax' => ['syntax' => 'short'],
'method_argument_space' => ['ensure_fully_multiline' => true],
'modernize_types_casting' => true,
'no_multiline_whitespace_before_semicolons' => true,
'multiline_whitespace_before_semicolons' => true,
'no_useless_else' => true,
'no_useless_return' => true,
'ordered_imports' => true,
Expand Down
2 changes: 1 addition & 1 deletion composer/helpers/v1/composer.json
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
"composer/composer": "^1.10.9"
},
"require-dev": {
"friendsofphp/php-cs-fixer": "^2.9",
"friendsofphp/php-cs-fixer": "^3.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So after chasing this a while, this won't work:

Bummer, but not a huge deal given that composer v1 support is essentially EOL at this point, and this PR gave me what I wanted which was an opportunity to learn how Composer works.

"phpstan/phpstan": "~1.8.5"
},
"autoload": {
Expand Down