Rename .php_cs -> .php-cs-fixer.dist.php
#5691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
rename-php_cs-to-php-cs-fixer.php
branch
from
17b4859
to
38da0fb
Compare
jeffwidman
force-pushed
the
rename-php_cs-to-php-cs-fixer.php
branch
from
38da0fb
to
2668005
Compare
jeffwidman
changed the title
.php_cs -> .php-cs-fixer.php.php_cs -> .php-cs-fixer.dist.php
jeffwidman
added a commit
to jeffwidman/dependabot-core
that referenced
this pull request
Sep 12, 2022
Per https://phpstan.org/config-reference#config-file: > The usual practice is to have `phpstan.neon.dist` or `phpstan.dist.neon` > under version control, and allow the user to override certain settings > in their environment (on their own computer or on a continuous > integration server) by creating `phpstan.neon` that’s present in > `.gitignore` file. I picked `phpstan.dist.neon` for consistency with `.php-cs-fixer.dist.php` config (dependabot#5691). I didn't add the file to `.gitignore` because I actually want to know if there starts being a new file under that name and see it in git...
|
Confirmed in https://github.com/dependabot/dependabot-core/actions/runs/3041101428/jobs/4897886119#step:4:6715 that it's using the new config file location: |
jurre
approved these changes
Sep 13, 2022
Fix deprecation warning by renaming the config file: ``` 15.95 > php-cs-fixer fix --diff --verbose '--dry-run' 16.10 You are running PHP CS Fixer v2, which is not maintained anymore. Please update to v3. 16.10 You may find an UPGRADE guide at https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.3.0/UPGRADE-v3.md . 16.10 If you need help while solving warnings, ask at https://gitter.im/PHP-CS-Fixer, we will help you! 16.10 16.10 PHP CS Fixer 2.19.3 Testament by Fabien Potencier and Dariusz Ruminski 16.10 Runtime: PHP 7.4.30 16.10 Loaded config default from "/opt/composer/v1/.php_cs". 16.14 ...... 16.26 Legend: ?-unknown, I-invalid file syntax (file ignored), S-skipped (cached or empty file), .-no changes, F-fixed, E-error 16.26 16.26 Checked all files in 0.134 seconds, 14.000 MB memory used 16.26 16.26 Detected deprecations in use: 16.26 - Configuration file `.php_cs` is deprecated, rename to `.php-cs-fixer.php`. ``` From https://github.com/dependabot/dependabot-core/actions/runs/3040792095/jobs/4897247001#step:6:6736 The warning suggests to rename to `php-cs-fixer.php`. However, looking at https://github.com/keradus/PHP-CS-Fixer/blob/master/UPGRADE-v3.md I see that is the recommended file name for the _local development_ config file. The distributed one should be `.php-cs-fixer.dist.php`, so I used that instead. More details on the distinction between the two types of files here: PHP-CS-Fixer/PHP-CS-Fixer#5607
jeffwidman
force-pushed
the
rename-php_cs-to-php-cs-fixer.php
branch
from
2668005
to
99a79c0
Compare
jeffwidman
added a commit
to jeffwidman/dependabot-core
that referenced
this pull request
Sep 13, 2022
Per https://phpstan.org/config-reference#config-file: > The usual practice is to have `phpstan.neon.dist` or `phpstan.dist.neon` > under version control, and allow the user to override certain settings > in their environment (on their own computer or on a continuous > integration server) by creating `phpstan.neon` that’s present in > `.gitignore` file. I picked `phpstan.dist.neon` for consistency with `.php-cs-fixer.dist.php` config (dependabot#5691). I didn't add the file to `.gitignore` because I actually want to know if there starts being a new file under that name and see it in git...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deprecation warning by renaming the config file:
From https://github.com/dependabot/dependabot-core/actions/runs/3040792095/jobs/4897247001#step:6:6736
The warning suggests to rename to
php-cs-fixer.php. However, lookingat https://github.com/keradus/PHP-CS-Fixer/blob/master/UPGRADE-v3.md I
see that is the recommended file name for the local development config file. The
distributed one should be
.php-cs-fixer.dist.php, so I used thatinstead. More details on the distinction between the two types of files
here: PHP-CS-Fixer/PHP-CS-Fixer#5607