Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade bundler to 2.3.14 #5479

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Downgrade bundler to 2.3.14 #5479

merged 1 commit into from
Aug 4, 2022

Conversation

jurre
Copy link
Member

@jurre jurre commented Aug 4, 2022

The latest versions of bundler has an issue where incomplete lockfiles that are
locked to "ruby" but not including exclusively gems NOT platform specific.

This causes an issue with existing lockfiles, generating a missing gem
error.

This is explained in more detail in: rubygems/rubygems#5807

Since this is currently preventing Dependabot updates for our users,
especially around sorbet dependencies, and since we have no good way to
signal these failures to them with an explanation on how to resolve it,
I think it's best that we downgrade bundler to a version that does not
include this, until rubygems/rubygems#5807 is
merged and we can bump to the latest version again.

@jurre
Copy link
Member Author

jurre commented Aug 4, 2022

Seems like there are some regressions in this version? The latest version that seemed to work was 2.3.14 so going to try that

The latest versions of bundler has an issue where incomplete lockfiles that are
locked to "ruby" but not including exclusively gems NOT platform specific.

This causes an issue with existing lockfiles, generating a missing gem
error.

This is explained in more detail in: rubygems/rubygems#5807

Since this is currently preventing Dependabot updates for our users,
especially around sorbet dependencies, and since we have no good way to
signal these failures to them with an explanation on how to resolve it,
I think it's best that we downgrade bundler to a version that does not
include this, until rubygems/rubygems#5807 is
merged and we can bump to the latest version again.
@jurre jurre changed the title Downgrade bundler to 2.3.16 Downgrade bundler to 2.3.14 Aug 4, 2022
@deivid-rodriguez
Copy link
Contributor

Yeah, I recall some issues around Ruby requirements, that's probably why we went from 2.3.13 to 2.3.18 directly last time.

@jurre jurre merged commit baf952a into main Aug 4, 2022
@jurre jurre deleted the jurre/bundler-2.3.16 branch August 4, 2022 10:31
@jurre jurre mentioned this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants