Add TODO note about removing parser warning #5462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I originally thought we were only hitting this warning due to Rubocop, and tried removing it, but it turns out we pull in this library for other code. I don't have time to dig deeper right now, so I filed dependabot#5461 explaining what I learned so far and this PR adds a TODO note in the code so the information doesn't get lost in the issue tracker.
|
Closing due to #5461 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally thought we were only hitting this warning due to Rubocop,
and tried removing it, but it turns out we pull in this library for
other code. I don't have time to dig deeper right now, so I filed
#5461 explaining
what I learned so far and this PR adds a TODO note in the code so the
information doesn't get lost in the issue tracker.