Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing builds #4184

Merged
merged 3 commits into from Sep 1, 2021
Merged

Fix failing builds #4184

merged 3 commits into from Sep 1, 2021

Conversation

xlgmokha
Copy link
Contributor

@xlgmokha xlgmokha commented Aug 31, 2021

Pinning to an older version of faraday appears to improve the condition of the builds. A new version of faraday was released yesterday.

A golang test is failing and I was able to reproduce it with:

~/src/github.com/dependabot/dependabot-core/go_modules/helpers [fix-build]
モ echo "{\"function\":\"getVcsRemoteForImport\",\"args\":{\"import\":\"code.cloudfoundry.org/bytefmt\"}}" | go run main.go
{"error":"Cannot detect VCS"}exit status 1

I was able to resolve this by falling back to http after attempting https resolution for paths that do not have a scheme specified.

@xlgmokha xlgmokha marked this pull request as ready for review August 31, 2021 16:38
@xlgmokha xlgmokha requested a review from a team as a code owner August 31, 2021 16:38
@@ -227,6 +227,7 @@ Dependabot and Dependabot Core started life as [Bump][bump] and
GoCardless in helping make Dependabot possible - if you need to collect
recurring payments from Europe, check them out.


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional noop added to highlight the build failure before and after pinning to a specific version of faraday. I'll see if I can work upstream to help identify the root cause.

@xlgmokha xlgmokha mentioned this pull request Aug 31, 2021
@xlgmokha xlgmokha changed the title Just a boy sitting in front of a computer trying to fix a few builds Fix failing builds Aug 31, 2021
@Nishnha
Copy link
Member

Nishnha commented Sep 1, 2021

Looks like there are a couple Go tests that have regressed from version updates. I think that pinning the Faraday version for stability here is the right call, though, and we can fix the Go tests in another PR. :shipit:

@xlgmokha
Copy link
Contributor Author

xlgmokha commented Sep 1, 2021

Thanks for approving this @Nishnha.

@jurre, @brrygrdn as per our conversation earlier I've disabled the flaky test for the time being and reverted the change to fallback to https. Do you mind double checking that I haven't included/excluded anything that wasn't discussed?

@Nishnha Nishnha mentioned this pull request Sep 1, 2021
@xlgmokha xlgmokha merged commit 1e88ab1 into main Sep 1, 2021
@xlgmokha xlgmokha deleted the fix-build branch September 1, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants