New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing builds #4184
Fix failing builds #4184
Conversation
@@ -227,6 +227,7 @@ Dependabot and Dependabot Core started life as [Bump][bump] and | |||
GoCardless in helping make Dependabot possible - if you need to collect | |||
recurring payments from Europe, check them out. | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional noop
added to highlight the build failure before and after pinning to a specific version of faraday. I'll see if I can work upstream to help identify the root cause.
Looks like there are a couple Go tests that have regressed from version updates. I think that pinning the Faraday version for stability here is the right call, though, and we can fix the Go tests in another PR. |
Pinning to an older version of faraday appears to improve the condition of the builds. A new version of faraday was released yesterday.
A golang test is failing and I was able to reproduce it with:
I was able to resolve this by falling back to http after attempting https resolution for paths that do not have a scheme specified.