Go modules ignore conditions #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt major This also signals a move to performing all of our Dependabot-specific logic in Ruby (which is the norm for most ecosystems), as opposed to splitting it between Ruby and Go.
Co-authored-by: David McIntosh <mctofu@github.com>
Co-authored-by: David McIntosh <mctofu@github.com>
mctofu
commented
May 4, 2021
go_modules/lib/dependabot/go_modules/update_checker/latest_version_finder.rb
Outdated
Show resolved
Hide resolved
mctofu
changed the title
thepwagner
approved these changes
May 5, 2021
There was a problem hiding this comment.
LGTM - I'm excited to ignore some versions.
Most of my time on this review was spent contemplating the path not taken - thanks for the clear and documented reasoning there!
| attr_reader :dependency, :dependency_files, :credentials, :ignored_versions | ||
|
|
||
| def fetch_latest_version | ||
| pseudo_version_regex = /\b\d{14}-[0-9a-f]{12}$/ |
There was a problem hiding this comment.
Idea: maybe extract+freeze as a constant?
During a version updates run we'll build several of these, we can squeak a few nanos by only compiling it once.
go_modules/lib/dependabot/go_modules/update_checker/latest_version_finder.rb
Show resolved
Hide resolved
| def filter_ignored_versions(versions_array) | ||
| filtered = versions_array. | ||
| reject { |v| ignore_requirements.any? { |r| r.satisfied_by?(v) } } | ||
| raise AllVersionsIgnored if @raise_on_ignored && filtered.empty? && versions_array.any? |
There was a problem hiding this comment.
Xref the conflict with #3644 , ezpz to resolve though!
| GOMOD | ||
| end | ||
|
|
||
| pending "doesn't update to the retracted version" do |
feelepxyz
reviewed
May 5, 2021
Co-Authored-By: Philip Harrison <feelepxyz@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in support for ignored versions for the go modules ecosystem in dependabot-core. It also extracts a
LatestVersionFinderclass which is common in the other ecosystems.This was an alternate approach to #3630. Instead of migrating to use
go list -m -versionswe stuck to using our existingupdatecheckerhelper but modified it to work more likego listwith these changes:With those changes in place applying the ignored version filter was fairly simple: 2bdbabc