Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check in/71266/remove 45 minute flag #29865

Conversation

brianseek
Copy link
Contributor

@brianseek brianseek commented May 17, 2024

Summary

Removes 45 minute feature flag and defaults to an on state for text and content.

Related issue(s)

Testing done

Updates tests

What areas of the site does it impact?

pre-check-in

Acceptance criteria

  • There is no 45 minute feature anymore
  • All content defaults to a state where the feature exists

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Copy link
Contributor

@wullaski wullaski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🧹

@brianseek brianseek merged commit 542424c into check-in/61390/unified-release-2 May 20, 2024
82 checks passed
@brianseek brianseek deleted the check-in/71266/remove-45-minute-flag branch May 20, 2024 15:57
brianseek added a commit that referenced this pull request May 29, 2024
* remove 45 minute feature and all related things.

* test clean up
brianseek added a commit that referenced this pull request May 30, 2024
* remove 45 minute feature and all related things.

* test clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants