Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upd: import pattern for PatientInboxPage #29864

Merged
merged 1 commit into from
May 21, 2024

Conversation

fazilqa
Copy link
Contributor

@fazilqa fazilqa commented May 17, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • This PR implements new import pattern for PatientInboxPage. This will reduce code lines quantity and make code more clean and readable

Related issue(s)

Testing done

  • All tests run in headless mode with no failures

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@fazilqa fazilqa requested review from a team as code owners May 17, 2024 21:32
@va-vfs-bot va-vfs-bot temporarily deployed to master/mhv-57674-new-import-inbox-page/main May 17, 2024 22:17 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/mhv-57674-new-import-inbox-page/main May 20, 2024 02:45 Inactive
@Asterix22 Asterix22 merged commit 0e3dfcd into main May 21, 2024
69 checks passed
@Asterix22 Asterix22 deleted the mhv-57674-new-import-inbox-page branch May 21, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants