Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

83339 Add back FDC (Fully Developed Claim) page #29863

Merged
merged 5 commits into from
May 20, 2024
Merged

Conversation

christinec-fftc
Copy link
Contributor

@christinec-fftc christinec-fftc commented May 17, 2024

Summary

  • Add back previously removed fully-developed-claim page
  • Remove default of standardClaim = false as this would cause a blocking error on the review and submit page
  • Modify maximal e2e test to cover standardClaim = true scenario
  • Fix bug preventing BDD claim submission from including standardClaim value

team: @department-of-veterans-affairs/dbex-trex
flipper: none

Related issue(s)

department-of-veterans-affairs/va.gov-team#83339

Testing done

Unit tests modernized and new tests added. E2E: added cases where standardClaim = true

Manual verification steps

Setup
Make sure these toggles are turned off: disability_526_toxic_exposure and disability_compensation_lighthouse_submit_migration

Original Claim with FDC = yes

  1. Start a new original claim for a new condition and/or CFI
  2. Fill out all required fields until you get to the fully-developed-claim page
  3. Verify: Make sure radio buttons for yes/no options are empty
  4. Verify: Hit 'Continue' button. Verify error displays for missing radio button value
  5. Verify: Select 'Yes' option. Verify alert shows as in screenshot
  6. Submit the claim
  7. Verify: Go to network tab and find the submit_all_claim request. Verify payload contains standardClaim: false
  8. Verify: If testing on staging, verify "FDC Program" box is checked on generated PDF

Original Claim with FDC = no

  1. Start a new original claim for a new condition and/or CFI
  2. Fill out all required fields until you get to the fully-developed-claim page
  3. Verify: Select 'No' option. Verify alert shows as in screenshot
  4. Submit the claim
  5. Verify: Go to network tab and find the submit_all_claim request. Verify payload contains standardClaim: true
  6. Verify: If testing on staging, verify "Standard Claim Process" box is checked on generated PDF

BDD

  1. Start a new BDD claim
  2. Fill out all required fields until you get to through the entire form
  3. Verify: Make sure fully-developed-claim page does not display for BDD claims
  4. Submit the claim
  5. Verify: Go to network tab and find the submit_all_claim request. Verify payload contains standardClaim: false
  6. Verify: If testing on staging, verify "BDD Program Claim" box is checked on generated PDF

Screenshots

The only visual change is not having a default value for the yes/no question. The rest of the screens are as they were before
FDC.pdf

What areas of the site does it impact?

526EZ

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@christinec-fftc christinec-fftc added the disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) label May 17, 2024
@christinec-fftc christinec-fftc marked this pull request as ready for review May 17, 2024 21:48
@christinec-fftc christinec-fftc requested review from a team as code owners May 17, 2024 21:48
@va-vfs-bot va-vfs-bot temporarily deployed to master/dbex/83339-fdc/main May 17, 2024 22:03 Inactive
@christinec-fftc christinec-fftc marked this pull request as draft May 18, 2024 00:42
@christinec-fftc christinec-fftc merged commit 526e679 into main May 20, 2024
80 of 81 checks passed
@christinec-fftc christinec-fftc deleted the dbex/83339-fdc branch May 20, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back FDC (Fully Developed Claim) page
3 participants