83339 Add back FDC (Fully Developed Claim) page #29863
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
standardClaim = false
as this would cause a blocking error on the review and submit pagestandardClaim = true
scenariostandardClaim
valueteam: @department-of-veterans-affairs/dbex-trex
flipper: none
Related issue(s)
department-of-veterans-affairs/va.gov-team#83339
Testing done
Unit tests modernized and new tests added. E2E: added cases where
standardClaim = true
Manual verification steps
Setup
Make sure these toggles are turned off:
disability_526_toxic_exposure
anddisability_compensation_lighthouse_submit_migration
Original Claim with FDC = yes
submit_all_claim
request. Verify payload containsstandardClaim: false
Original Claim with FDC = no
submit_all_claim
request. Verify payload containsstandardClaim: true
BDD
submit_all_claim
request. Verify payload containsstandardClaim: false
Screenshots
The only visual change is not having a default value for the yes/no question. The rest of the screens are as they were before
FDC.pdf
What areas of the site does it impact?
526EZ
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
#sitewide-public-websites
Slack channel for questionsRequested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?