Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC | Code cleanup #29862

Merged
merged 4 commits into from
May 21, 2024
Merged

SC | Code cleanup #29862

merged 4 commits into from
May 21, 2024

Conversation

Mottie
Copy link
Contributor

@Mottie Mottie commented May 17, 2024

Summary

  • (Summarize the changes that have been made to the platform)
    • Fix spacing on evidence summary page to be more consistent with the design
    • Change "Remove" uploaded file button to "Delete"
    • Fix flaky maximal e2e test
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution)
    • Match the design
    • Remove ?index= from e2e url check since it isn't included all the time
  • (Which team do you work for, does your team own the maintenance of this component?)

    Decision Reviews Team

  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

#83404

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Evidence summary Screenshot 2024-05-17 at 3 37 18 PM Screenshot 2024-05-17 at 3 37 51 PM

What areas of the site does it impact?

Supplemental Claims

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/83404-dr-cleanup/main May 20, 2024 14:21 Inactive
Copy link
Contributor

@anniebtran anniebtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mottie Mottie merged commit 9e1d8b0 into main May 21, 2024
69 checks passed
@Mottie Mottie deleted the 83404-dr-cleanup branch May 21, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants