Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding mock server to appoint a rep #29861

Merged
merged 4 commits into from
May 22, 2024
Merged

Adding mock server to appoint a rep #29861

merged 4 commits into from
May 22, 2024

Conversation

cosu419
Copy link
Contributor

@cosu419 cosu419 commented May 17, 2024 •
edited

Summary

This PR adds a mock server (along with test fixtures) to the newly generated representative-appoint app.

It also contains a copy change to the representative status widget.

Related issue(s)

@cosu419 cosu419 requested a review from a team as a code owner May 17, 2024 20:36
va-vfs-bot
va-vfs-bot reviewed May 17, 2024
View reviewed changes
Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

src/applications/representative-appoint/mocks/endpoints/personal-information/index.js
@@ -0,0 +1,185 @@
/* eslint-disable camelcase */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

@cosu419 cosu419 changed the title Co 051724 adding mock server to appoint a rep Adding mock server to appoint a rep May 20, 2024
@cosu419 cosu419 merged commit 5f2f4ea into main May 22, 2024
68 of 69 checks passed
@cosu419 cosu419 deleted the co-051724-adding-mock-server-to-appoint-a-rep branch May 22, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@va-vfs-bot va-vfs-bot va-vfs-bot left review comments

@opticbob opticbob opticbob approved these changes

@harshil1793 harshil1793 harshil1793 approved these changes

@jvcAdHoc jvcAdHoc jvcAdHoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cosu419 @opticbob @harshil1793 @va-vfs-bot @jvcAdHoc