Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pensions adjust helper text #29859

Merged
merged 4 commits into from
May 21, 2024
Merged

Pensions adjust helper text #29859

merged 4 commits into from
May 21, 2024

Conversation

TaiWilkin
Copy link
Contributor

Summary

On /medical/history/va-treatment/medical-centers, /va-treatment/medical-centers, /medical/history/federal-treatment/medical-centers, /employment/current/history, /employment/previous/history, the text "Enter all VA medical centers where you have received treatment" was not announced by screen readers when tabbing to the first input. This moves the secondary legend into the first as a span with styling to maintain the existing appearance, following the recommended action from platform.

Related issue(s)

department-of-veterans-affairs/va.gov-team#82852

Testing done

  • Visit each of the routes listed above with a screenreader and confirm in the developer tools that the 'Enter all the...' text is within the page legend, that the text is read, and that the components appear the same as before.

Screenshots

Before After
VA Medical Centers Screenshot 2024-05-17 at 3 40 45 PM Screenshot 2024-05-17 at 10 48 29 AM
Federal Medical Centers Screenshot 2024-05-17 at 3 41 40 PM Screenshot 2024-05-17 at 10 48 43 AM
Current Employment Screenshot 2024-05-17 at 3 42 32 PM Screenshot 2024-05-17 at 10 48 57 AM
Previous Employment Screenshot 2024-05-17 at 3 43 07 PM Screenshot 2024-05-17 at 10 49 25 AM

What areas of the site does it impact?

Pension Benefits

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@TaiWilkin TaiWilkin changed the title Pensions 82852 adjust helper text Pensions adjust helper text May 17, 2024
@TaiWilkin TaiWilkin added the pension-benefits Label used for Pull Requests/Issues that impact Pension Claims claims (CH36, 25-8832) label May 17, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/pensions-82852-adjust-helper-text/main May 17, 2024 20:20 Inactive
@TaiWilkin TaiWilkin marked this pull request as ready for review May 21, 2024 16:12
@TaiWilkin TaiWilkin requested review from a team as code owners May 21, 2024 16:12
@TaiWilkin TaiWilkin merged commit e9a2649 into main May 21, 2024
68 checks passed
@TaiWilkin TaiWilkin deleted the pensions-82852-adjust-helper-text branch May 21, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pension-benefits Label used for Pull Requests/Issues that impact Pension Claims claims (CH36, 25-8832)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants