Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed console logging from 10-7959f-1 now that SIP works #29858

Merged
merged 1 commit into from
May 20, 2024

Conversation

michaelclement
Copy link
Contributor

Summary

This PR removes some startup console logging from form 10-7959f-1 that was used while we troubleshot the SIP functionality.

  • Removes console logging from form 10-7959f-1
  • Team: IVC CHAMPVA
  • Flipper: NA

Related issue(s)

  • NA

Testing done

  • Manual

What areas of the site does it impact?

This form only

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

NA

@michaelclement michaelclement marked this pull request as ready for review May 17, 2024 18:59
@michaelclement michaelclement requested a review from a team as a code owner May 17, 2024 18:59
@michaelclement michaelclement changed the title removed coonsole logging from 10-7959f-1 now that SIP works removed console logging from 10-7959f-1 now that SIP works May 17, 2024
@michaelclement michaelclement merged commit ab19e32 into main May 20, 2024
75 checks passed
@michaelclement michaelclement deleted the remove-logging-from-f1 branch May 20, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants