Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10-7959f-2 Veteran Info Page #29857

Merged
merged 1 commit into from
May 21, 2024
Merged

10-7959f-2 Veteran Info Page #29857

merged 1 commit into from
May 21, 2024

Conversation

reiting
Copy link
Contributor

@reiting reiting commented May 17, 2024

Summary

This PR covers the veteran info page according to current designs on Figma. Some changes were made to the intro page also to facilitate the veteran info page.

Related issue(s)

department-of-veterans-affairs/va.gov-team#82067

Testing done

Visual Testing as this is not a completed design yet, but is just basic.

Screenshots

Screenshot 2024-05-17 at 2 46 59 PM
Screenshot 2024-05-17 at 2 47 14 PM

What areas of the site does it impact?

This form only

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

NA

@reiting reiting marked this pull request as ready for review May 17, 2024 18:56
@reiting reiting requested a review from a team as a code owner May 17, 2024 18:56
@reiting reiting merged commit b20073b into main May 21, 2024
74 of 75 checks passed
@reiting reiting deleted the 10-7959f-2-veteran-info branch May 21, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants