Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-rx-breadcrumbs #29853

Merged
merged 4 commits into from
May 20, 2024
Merged

update-rx-breadcrumbs #29853

merged 4 commits into from
May 20, 2024

Conversation

agravell047
Copy link
Contributor

@agravell047 agravell047 commented May 17, 2024

Summary

  • Added the "VA.gov home" link as the first breadcrumb for medications app
  • Removed the word "home" from the MHV home link

Related issue(s)

No ticket linked, issue was brought up over Slack

Testing done

  • Tested locally
  • Updated unit tests

Screenshots

Screenshot 2024-05-17 at 12 33 21 PM

What areas of the site does it impact?

MHV medications app

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/update-rx-breadcrumbs/main May 17, 2024 17:38 Inactive
@agravell047 agravell047 merged commit 77d5b2c into main May 20, 2024
65 checks passed
@agravell047 agravell047 deleted the update-rx-breadcrumbs branch May 20, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants