Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHV-57660 reworked reply draft page to follow new design #29852

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

KolbyVA
Copy link
Contributor

@KolbyVA KolbyVA commented May 17, 2024

Summary

Reworks the draft reply page in accordance with new "multiple draft" solution designs. Also has minor tweaks for thread list page.

Related issue(s)

https://jira.devops.va.gov/browse/MHV-57660

Modify "Reply" button for multiple draft scenario (See details below)

User Story: As a Secure Messaging User, I want to be able to have multiple drafts in a message thread.

Testing done

Manual testing tbd in Review Instance.

Screenshots

Desktop:

image

Mobile:

image

What areas of the site does it impact?

Secure-messaging

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 17, 2024 17:06 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 17, 2024 18:43 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 20, 2024 16:08 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 20, 2024 17:21 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 20, 2024 21:36 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 21, 2024 15:56 Inactive
Copy link
Contributor

@oleksii-morgun oleksii-morgun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Good unit test coverage. I highlighted few things to look at

@oleksii-morgun
Copy link
Contributor

This may have brought up already, but I am noticing that upon clicking Edit draft replies, Draft accordions are expanded but the accordion set still has Expand all+ buttons instead of Collapse all-
image

@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 23, 2024 15:38 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 23, 2024 15:57 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 23, 2024 16:24 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 23, 2024 17:02 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 23, 2024 18:28 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 29, 2024 01:42 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 29, 2024 20:40 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 30, 2024 02:59 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 30, 2024 14:54 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 30, 2024 20:14 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 30, 2024 21:01 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 31, 2024 01:44 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 31, 2024 01:47 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 31, 2024 13:19 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 31, 2024 13:46 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 31, 2024 18:50 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-57660-Multidraft-solution/main May 31, 2024 19:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants