-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MHV-57660 reworked reply draft page to follow new design #29852
Draft
KolbyVA
wants to merge
30
commits into
main
Choose a base branch
from
MHV-57660-Multidraft-solution
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+714
−464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 17, 2024 17:06
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 17, 2024 18:43
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 20, 2024 16:08
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 20, 2024 17:21
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 20, 2024 21:36
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 21, 2024 15:56
Inactive
src/applications/mhv-secure-messaging/components/ComposeForm/ComposeFormActionButtons.jsx
Show resolved
Hide resolved
src/applications/mhv-secure-messaging/components/ComposeForm/ReplyDraftItem.jsx
Outdated
Show resolved
Hide resolved
oleksii-morgun
requested changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Good unit test coverage. I highlighted few things to look at
src/applications/mhv-secure-messaging/components/ComposeForm/ComposeFormActionButtons.jsx
Show resolved
Hide resolved
src/applications/mhv-secure-messaging/components/ComposeForm/FileInput.jsx
Outdated
Show resolved
Hide resolved
src/applications/mhv-secure-messaging/components/Draft/DeleteDraft.jsx
Outdated
Show resolved
Hide resolved
src/applications/mhv-secure-messaging/components/ComposeForm/ComposeFormActionButtons.jsx
Outdated
Show resolved
Hide resolved
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 23, 2024 15:38
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 23, 2024 15:57
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 23, 2024 16:24
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 23, 2024 17:02
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 23, 2024 18:28
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 23, 2024 18:48
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 23, 2024 20:48
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 29, 2024 01:42
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 29, 2024 20:40
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 30, 2024 02:59
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 30, 2024 14:54
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 30, 2024 20:14
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 30, 2024 21:01
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 31, 2024 01:44
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 31, 2024 01:47
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 31, 2024 13:19
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 31, 2024 13:46
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 31, 2024 18:50
Inactive
va-vfs-bot
temporarily deployed
to
master/MHV-57660-Multidraft-solution/main
May 31, 2024 19:41
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the draft reply page in accordance with new "multiple draft" solution designs. Also has minor tweaks for thread list page.
Related issue(s)
https://jira.devops.va.gov/browse/MHV-57660
Testing done
Manual testing tbd in Review Instance.
Screenshots
Desktop:
Mobile:
What areas of the site does it impact?
Secure-messaging
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
#sitewide-public-websites
Slack channel for questionsRequested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?