Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check in/63914/add accordion to appointments page #29849

Conversation

wullaski
Copy link
Contributor

Summary

  • Adds accordion to appointment page

Wireframes

Related issue(s)

Testing done

  • Unit
  • Visual

Screenshots

Screenshot 2024-05-17 at 11 33 42 AM

What areas of the site does it impact?

Check-in -> New landing page

Acceptance criteria

  • Content matches that of the wireframes
  • Acceptable test coverage

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

@wullaski wullaski requested review from a team as code owners May 17, 2024 15:37
Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

import React, { useMemo } from 'react';
import { useSelector, useDispatch } from 'react-redux';
import PropTypes from 'prop-types';
// eslint-disable-next-line import/no-unresolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

import React from 'react';
import { useTranslation } from 'react-i18next';
import PropTypes from 'prop-types';
// eslint-disable-next-line import/no-unresolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

@@ -0,0 +1,74 @@
/* eslint-disable camelcase */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

@@ -0,0 +1,141 @@
/* eslint-disable camelcase */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

Copy link
Contributor

@brianseek brianseek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wullaski wullaski force-pushed the check-in/63914/add-accordion-to-appointments-page branch from 3db1a25 to e58f164 Compare May 20, 2024 14:28
@wullaski wullaski merged commit 3116efb into check-in/61390/unified-release-2 May 20, 2024
76 checks passed
@wullaski wullaski deleted the check-in/63914/add-accordion-to-appointments-page branch May 20, 2024 14:54
brianseek pushed a commit that referenced this pull request May 29, 2024
brianseek pushed a commit that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants