Update primary action link & remove useless prop #29848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/simple-forms/form-upload/update-primary-action-links/main
pennja
reviewed
May 20, 2024
Comment on lines
31
to
40
| <div className="arrow" style={{ maxWidth: '75%' }}> | ||
| <div className="vads-u-background-color--primary vads-u-padding--1"> | ||
| <a | ||
| className="vads-c-action-link--white" | ||
| href={`/form-upload/${formNumber}`} | ||
| > | ||
| Start uploading your form | ||
| </a> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Given that we're using this exact same component in multiple places now, I'd love it if this could be defined in a common space and instantiated where necessary. Do we have such a spot we can park this component?
pennja
reviewed
May 20, 2024
Comment on lines
1
to
15
| .arrow { | ||
| position: relative; | ||
| } | ||
|
|
||
| .arrow::after { | ||
| content: ""; | ||
| position: absolute; | ||
| top: 0; | ||
| right: -24px; | ||
| width: 0; | ||
| height: 0; | ||
| border-top: 24px solid transparent; | ||
| border-bottom: 24px solid transparent; | ||
| border-left: 24px solid var(--vads-color-primary); | ||
| } |
pennja
reviewed
May 20, 2024
There was a problem hiding this comment.
Overall, this is straightforward and looks good! I'd really like to eliminate the code duplication and more importantly reduce points of potential divergence between the multiple iterations of this component so I'd like to see them combined into one definition if at all possible.
va-vfs-bot
temporarily deployed
to
master/simple-forms/form-upload/update-primary-action-links/main
rhasselle-oddball
approved these changes
May 21, 2024
powellkerry
approved these changes
May 21, 2024
Thrillberg
deleted the
simple-forms/form-upload/update-primary-action-links
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the primary action link on the form upload flow. It also removes a prop that we don't use on the
content-buildside so it is useless. We'll switch on whether a form has the form upload flow purely on thecontent-buildside, not here.Related issue(s)
https://app.zenhub.com/workspaces/vagov-product-team-forms-634853151f5c6000165942bc/issues/gh/department-of-veterans-affairs/va.gov-team-forms/1280
Screenshots