Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Content for addDisabilitiesRevised Page #29846

Merged
merged 6 commits into from
May 21, 2024

Conversation

tyler-spangler6
Copy link
Contributor

@tyler-spangler6 tyler-spangler6 commented May 17, 2024

Summary

This updates the content and instructions for the addDisabilities page. The new content has been through Veteran testing and provides more instructions for Veterans as the use the new combobox component to add conditions for disability compensation. Additionally, this updates the messages for validation of Veteran inputs. This content is behind the feature flag disability_526_improved_autosuggestions_add_disabilities_page.

Related issue(s)

Testing done

  • Unit tests are included in `addDisabilitiesRevised.unit.spec.jsx.

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

These changes are implemented in the 526EZ form in the addDisabilitiesRevised page.

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/cc-468-update-content/main May 17, 2024 14:47 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/cc-468-update-content/main May 17, 2024 15:51 Inactive
mchae-nava
mchae-nava previously approved these changes May 20, 2024
Copy link
Contributor

@mchae-nava mchae-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code pass LGTM

@tyler-spangler6 tyler-spangler6 requested a review from a team as a code owner May 20, 2024 15:48
@va-vfs-bot va-vfs-bot temporarily deployed to master/cc-468-update-content/main May 20, 2024 16:02 Inactive
tjheffner
tjheffner previously approved these changes May 20, 2024
@lukey-luke
Copy link
Contributor

Text content looks good to me.

I left a comment on #468 for some style differences from the spec I saw in the mobile view.

lukey-luke
lukey-luke previously approved these changes May 20, 2024
@tyler-spangler6 tyler-spangler6 dismissed stale reviews from lukey-luke and tjheffner via 78a9b07 May 20, 2024 18:02
Copy link
Contributor

@lukey-luke lukey-luke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the label string. LGTM

Copy link
Contributor

@lukey-luke lukey-luke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the combobox title. LGTM.

@tyler-spangler6 tyler-spangler6 merged commit a030f0b into main May 21, 2024
79 of 80 checks passed
@tyler-spangler6 tyler-spangler6 deleted the cc-468-update-content branch May 21, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants