76692 - [FSR] - Use Assets New data BE data/calcs #29844
Conversation
va-vfs-bot
temporarily deployed
to
master/fsr/76692/use-assets-calcs/main
There was a problem hiding this comment.
Sentry call found
Sentry captures a lot of data, and we want to make sure that we only keep information that will be useful for troubleshooting issues. This means that PII should not be recorded.
What you can do
Review your call to Sentry and see if you can reasonably reduce any information that is included, or wait for a VSP review.
|
|
||
| return await apiRequest(url, options); | ||
| } catch (error) { | ||
| Sentry.withScope(scope => { |
| } catch (error) { | ||
| Sentry.withScope(scope => { | ||
| scope.setExtra('error', error); | ||
| Sentry.captureMessage( |
va-vfs-bot
temporarily deployed
to
master/fsr/76692/use-assets-calcs/main
va-vfs-bot
temporarily deployed
to
master/fsr/76692/use-assets-calcs/main
There was a problem hiding this comment.
Sentry call found
Sentry captures a lot of data, and we want to make sure that we only keep information that will be useful for troubleshooting issues. This means that PII should not be recorded.
What you can do
Review your call to Sentry and see if you can reasonably reduce any information that is included, or wait for a VSP review.
| }, | ||
| }); | ||
| } catch (error) { | ||
| Sentry.withScope(scope => { |
| }); | ||
| } catch (error) { | ||
| Sentry.withScope(scope => { | ||
| scope.setExtra('error', error); |
| }, | ||
| }); | ||
| } catch (error) { | ||
| Sentry.withScope(scope => { |
| } catch (error) { | ||
| Sentry.withScope(scope => { | ||
| scope.setExtra('error', error); | ||
| Sentry.captureMessage( |
va-vfs-bot
temporarily deployed
to
master/fsr/76692/use-assets-calcs/main
There was a problem hiding this comment.
Sentry call found
Sentry captures a lot of data, and we want to make sure that we only keep information that will be useful for troubleshooting issues. This means that PII should not be recorded.
What you can do
Review your call to Sentry and see if you can reasonably reduce any information that is included, or wait for a VSP review.
| } catch (error) { | ||
| Sentry.withScope(scope => { | ||
| scope.setExtra('error', error); | ||
| Sentry.captureMessage( |
va-vfs-bot
temporarily deployed
to
master/fsr/76692/use-assets-calcs/main
va-vfs-bot
temporarily deployed
to
master/fsr/76692/use-assets-calcs/main
va-vfs-bot
temporarily deployed
to
master/fsr/76692/use-assets-calcs/main
|
Fixed merge conflicts from merging expenses endpoint implementation. |
va-vfs-bot
temporarily deployed
to
master/fsr/76692/use-assets-calcs/main
va-vfs-bot
temporarily deployed
to
master/fsr/76692/use-assets-calcs/main
There was a problem hiding this comment.
After looking at what we replaced and the feature flags, I'm not sure we need this calculation anymore! Especially once the streamlinedWaiverAssetUpdate has been deprecated. The API returns total assets, and we're only looking at liquid for streamlined calculations
Summary
Replace local asset calculations with API response.
Related issue(s)
department-of-veterans-affairs/va.gov-team#76692
Testing done
Log into app, submit a streamlined long and full FSR.
Screenshots
What areas of the site does it impact?
FSR
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
#sitewide-public-websitesSlack channel for questionsRequested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?