Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contact info edit errors #29841

Merged
merged 5 commits into from
May 20, 2024
Merged

Update contact info edit errors #29841

merged 5 commits into from
May 20, 2024

Conversation

Mottie
Copy link
Contributor

@Mottie Mottie commented May 17, 2024

Summary

  • (Summarize the changes that have been made to the platform)

    Updating error messages from using "Please" to "You must" per CAIA recommendations. After changing the fallback error messages in platform, updating numerous tests became necessary.

  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution)
  • (Which team do you work for, does your team own the maintenance of this component?)

    Benefits Decision Reviews

  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

#81600

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Before After
Email error Screenshot 2024-05-17 at 7 17 13 AM Screenshot 2024-05-16 at 12 18 38 PM
Mobile phone error Screenshot 2024-05-17 at 7 16 39 AM Screenshot 2024-05-16 at 12 18 26 PM
Address errors Screenshot 2024-05-17 at 7 17 44 AM Screenshot 2024-05-16 at 12 18 09 PM

What areas of the site does it impact?

  • Forms that use platform default schema error messages
  • Forms that use profile contact info fields
  • Tests from Disability benefits
  • Tests from profile
  • Tests from VAOS

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@Mottie Mottie self-assigned this May 17, 2024
@Mottie Mottie marked this pull request as ready for review May 17, 2024 16:20
@Mottie Mottie requested review from a team as code owners May 17, 2024 16:20
Copy link
Contributor

@simiadebowale simiadebowale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mottie Mottie merged commit 4558f84 into main May 20, 2024
73 checks passed
@Mottie Mottie deleted the 81600-contact-edit-errors branch May 20, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants