Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask VA 977 - Design Changes for Tell us about the Veteran - "Veteran postal code" #29837

Conversation

hemeshvpatel
Copy link
Contributor

@hemeshvpatel hemeshvpatel commented May 16, 2024

Summary

  • Renamed files and variables to better reflect figma file "Veteran Postal Code"
  • Updated UI and Schema per figma
  • The Ask VA team owns this page
  • This is part of our POC

Related issue(s)

  • Link to ticket here

Testing done

  • Manual testing with conditionals and checkbox
  • Update test veteransPostalCode.unit.spec.js

Screenshots

image

What areas of the site does it impact?

  • This only impacts the Ask VA form

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

…tional Info banner and make checkbox conditional to show accordingly.
@hemeshvpatel hemeshvpatel self-assigned this May 16, 2024
Copy link
Contributor

@Khoa-V-Nguyen Khoa-V-Nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hemeshvpatel hemeshvpatel marked this pull request as ready for review May 17, 2024 15:14
@hemeshvpatel hemeshvpatel requested a review from a team as a code owner May 17, 2024 15:14
Copy link
Contributor

@Khoa-V-Nguyen Khoa-V-Nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hemeshvpatel hemeshvpatel merged commit 2f4ebe4 into main May 21, 2024
74 of 75 checks passed
@hemeshvpatel hemeshvpatel deleted the Ask-VA-977/Design-Changes-for-Tell-us-about-the-Veteran--Veteran-postal-code branch May 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants