Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIMPLE_FORMS] fix: 21-4138 - add validation to other checkbox selection #29835

Merged
merged 1 commit into from
May 20, 2024
Merged

[SIMPLE_FORMS] fix: 21-4138 - add validation to other checkbox selection #29835

merged 1 commit into from
May 20, 2024

Conversation

pennja
Copy link
Contributor

@pennja pennja commented May 16, 2024

Summary

  • Updates checkbox validation function name to be more generic
  • Updates other reasons checkbox group to use this validation
  • Configured form 21-4138 to utilize new custom link logic
  • Team: Veteran Facing Forms
  • Flipper not implemented

Related issue(s)

  • department-of-veterans-affairs/va.gov-team-forms#1296

Testing done

  • Local browser functions successfully
  • Unit tests successful
  • E2E tests successful

What areas of the site does it impact?

This form ONLY.

@pennja pennja requested a review from a team as a code owner May 16, 2024 20:31
@va-vfs-bot va-vfs-bot temporarily deployed to master/jap/simple-forms/1296-error/main May 16, 2024 21:44 Inactive
@pennja pennja force-pushed the jap/simple-forms/1296-error branch from 2bfc142 to 7ce58f8 Compare May 17, 2024 15:58
@pennja pennja merged commit 10bb07c into main May 20, 2024
80 checks passed
@pennja pennja deleted the jap/simple-forms/1296-error branch May 20, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhasselle-oddball rhasselle-oddball rhasselle-oddball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pennja @rhasselle-oddball @va-vfs-bot