Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-35243] Add poa create request service - Part 2 #16737

Merged
merged 2 commits into from
May 15, 2024

Conversation

jvcAdHoc
Copy link
Contributor

@jvcAdHoc jvcAdHoc commented May 14, 2024

Summary

  • This pr finishes the POA request orchestration service by adding a poa request creation service that chains the many BGS calls

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Tested services locally with BGS proxy

What areas of the site does it impact?

Will impact claims api POA V2 once in use

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@jvcAdHoc jvcAdHoc added the claimsApi modules/claims_api label May 14, 2024
@jvcAdHoc jvcAdHoc self-assigned this May 14, 2024
Copy link

github-actions bot commented May 14, 2024

1 Error
🚫 This PR changes 777 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • modules/claims_api/app/services/claims_api/power_of_attorney_request_service/create_request.rb (+272/-0)

  • modules/claims_api/app/services/claims_api/power_of_attorney_request_service/orchestrator.rb (+6/-1)

  • modules/claims_api/spec/lib/claims_api/vnp_proc_form_service_spec.rb (+1/-1)

  • modules/claims_api/spec/services/power_of_attorney_request_service/create_request_spec.rb (+349/-0)

  • modules/claims_api/spec/services/power_of_attorney_request_service/orchestrator_spec.rb (+138/-0)

  • modules/claims_api/spec/services/power_of_attorney_request_service/terminate_existing_requests_spec.rb (+8/-1)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to API-35243-create-new-poa-request/main/main May 14, 2024 13:03 Inactive
@jvcAdHoc jvcAdHoc marked this pull request as ready for review May 14, 2024 13:27
@jvcAdHoc jvcAdHoc requested a review from a team as a code owner May 14, 2024 13:27
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jvcAdHoc jvcAdHoc force-pushed the API-35243-create-new-poa-request branch from 400c81e to 2401efb Compare May 15, 2024 15:45
@jvcAdHoc jvcAdHoc merged commit 50a00ee into master May 15, 2024
18 of 19 checks passed
@jvcAdHoc jvcAdHoc deleted the API-35243-create-new-poa-request branch May 15, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants