BGSClient rework for static action -> service -> bean definitions

[nihil2501]

Changes

• Consolidate XML builder helper into BGSClient.perform_request
  • Simplified the calls to BGS in the POA request search and decide code
  • Now the body can either be passed in as an argument or a block can be provided that leverages this helper (but not both)
  • (This is what initiated the snowball into reconsidering namespaces)
• Hardcode data namespace alias (based on this BGS-wide audit of beans with >1 namespace) since the alias is arbitrary (but it should be chosen so that it doesn't collide with any standard ones like soap)
• No longer fetching WSDL in order to extract namespaces
  • To enable this, service action is remodeled as action -> service -> bean in order to get the bean definition's static namespaces (still nee to determine it truly is static)
  • Adapter function added to LocalBGSRefactored adapter to locate the right hardcoded definition (so all existing calls to LocalBGS would also stop fetching the WSDL if we migrate)
    • ClaimantWebService and EBenefitsBnftClaimStatusWebService already added in order to get local_bgs_refactored_spec (which duplicates local_bgs_spec) to pass, which was a decent test of the lookup function
• BGSClient.healthcheck now accepts a proper service definition due to the above remodel
• Unrelated change to proxy breakers_service to make that transparent in the migration as well

[github-actions]

1 Error

🚫

This PR changes 676 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, those exceeding 500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into smaller ones. If you have reason to believe that this PR should be granted an exception, please see the Submitting pull requests for approval - FAQ. File Summary Files modules/claims_api/app/clients/claims_api/bgs_client.rb (+23/-77) modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb (+116/-0) modules/claims_api/app/clients/claims_api/bgs_client/request.rb (+43/-71) modules/claims_api/app/clients/claims_api/bgs_client/request/envelope.rb (+42/-13) modules/claims_api/app/clients/claims_api/bgs_client/service_action.rb (+0/-42) modules/claims_api/app/services/claims_api/power_of_attorney_request_service/decide.rb (+7/-16) modules/claims_api/app/services/claims_api/power_of_attorney_request_service/helpers/xml_builder.rb (+0/-32) modules/claims_api/app/services/claims_api/power_of_attorney_request_service/search.rb (+12/-17) modules/claims_api/lib/bgs_service/local_bgs_proxy.rb (+13/-6) modules/claims_api/lib/bgs_service/local_bgs_refactored.rb (+34/-29) modules/claims_api/lib/bgs_service/local_bgs_refactored/find_service_definition.rb (+52/-0) modules/claims_api/spec/lib/claims_api/local_bgs_refactored_spec.rb (+7/-8) modules/claims_api/spec/requests/v2/power_of_attorney_requests/decline/request_spec.rb (+2/-2) modules/claims_api/spec/requests/v2/power_of_attorney_requests/index/request_spec.rb (+1/-1) modules/claims_api/spec/support/bgs_client_spec_helpers.rb (+6/-4) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[FonzMP]