Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE | Ask VA Api: Fix InquiriesController #16735

Merged
merged 1 commit into from
May 14, 2024

Conversation

Khoa-V-Nguyen
Copy link
Contributor

Summary

  • Fixed InquiriesController

Testing done

  • New code is covered by unit tests

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

@Khoa-V-Nguyen Khoa-V-Nguyen self-assigned this May 14, 2024
@Khoa-V-Nguyen Khoa-V-Nguyen requested review from a team as code owners May 14, 2024 00:25
Copy link
Contributor

@joehall-tw joehall-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Assuming the whitespace edits were to satisfy linting.

@Khoa-V-Nguyen Khoa-V-Nguyen merged commit 30609d5 into master May 14, 2024
20 checks passed
@Khoa-V-Nguyen Khoa-V-Nguyen deleted the ask-va-api-fix-inquiry-create branch May 14, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants