Resolve alias_attribute Deprecation Warnings

[stevenjcumming]

Summary

• Remove a deprecation warning from two files
  • app/models/form526_job_status.rb
  • app/models/saved_claim/disability_compensation.rb
• switched to alias for Form526JobStatus
• remove alias_attribute for SavedClaim::DisabilityCompensation because isn't used anymore
  • Model- Old 526 Submission Flow Cleanup #4039

Related issue(s)

• Resolve alias_attribute Deprecation Warnings va.gov-team#83001

Testing done

• Run test suite locally

Acceptance criteria

• No alias_attribute deprecation warnings in the CI logs

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/models/saved_claim/disability_compensation.rb

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/models/saved_claim/disability_compensation.rb

[freeheeling]

LGTM