-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[81760] Adding special error case to ToU provisioner response when user cannot be provisioned #16731
[81760] Adding special error case to ToU provisioner response when user cannot be provisioned #16731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to change the log here? Maybe the intent is to log that the call itself was successful but it is kinda confusing how we log update provisioning success
when provisioning fails. these are the logs we get for a failed
provisioning:
Rails -- [MAP][SignUp][Service] update provisioning success, icn: 1008596379V859838
Rails -- [TermsOfUse] [Provisioner] update_provisioning error -- { :icn => "1008596379V859838", :response => { :agreement_signed => true, :opt_out => false, :cerner_provisioned => false, :bypass_eligible => true } }
Rails -- [TermsOfUseAgreementsController] update_provisioning error: Account not Provisioned -- { :icn => "1008596379V859838" }```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still want to say 'success' but maybe give more context, like the json array with tou status, provision status, etc. Cause it is technically a successful call to that endpoint, it's just the response makes us error |
e62eb74
to
250f8db
Compare
I updated the log to still say |
…er cannot be provisioned
250f8db
to
f1b5da7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Summary
Related issue(s)
Testing done
update_provisioning
andaccept_and_provision
returned an error with the messageAccount not Provisioned
What areas of the site does it impact?
Acceptance criteria
update_provisioning
mock should have theCernerProvisioned: false
field to create this errorterms_of_use_agreements/update_provisioning
andterms_of_use_agreements/:version/accept_and_provision
Account not provisioned