API-36406 Adjust docker container upload job tests

[rockwellwindsor-va]

Summary

• Updates some tests in the disability_compensation_docker_container_upload_spec.rb file that were not running as expected.
  • Adjusts claim variable for relevant tests so the claim being sent into the job is the same one used in the expectations. Linked example to make it easier to see
  • Tests retry behavior by directly sending in error to will_retry? method once error raises
  • Removes jobs counting on tests that run sync
  • Adds an expectation to verify the related saved error message just for further reliability

Related issue(s)

API-36406

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
• If this work is behind a flipper:
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

• modules/claims_api/app/sidekiq/claims_api/service_base.rb
• modules/claims_api/spec/sidekiq/claim_custom_error_spec.rb (typo fix)
• modules/claims_api/spec/sidekiq/service_base_spec.rb
• modules/claims_api/spec/sidekiq/v2/disability_compensation_docker_container_upload_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

[github-actions]

1 Warning

⚠️

This PR changes 348 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/claims_api/app/sidekiq/claims_api/v2/disability_compensation_docker_container_upload.rb (+1/-2) modules/claims_api/spec/sidekiq/claim_custom_error_spec.rb (+1/-1) modules/claims_api/spec/sidekiq/service_base_spec.rb (+54/-14) modules/claims_api/spec/sidekiq/v2/disability_compensation_docker_container_upload_spec.rb (+137/-138) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[rockwellwindsor-va]

I felt it was relevant enough to include these additions. I wanted to lock this in for will_retry? so this could not revert in the future.

[stiehlrod]

LGTM